Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never-supported WebRTC APIs #6940

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 16, 2020
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@queengooborg queengooborg merged commit 40b2eb2 into mdn:master Nov 18, 2020
@saschanaz saschanaz deleted the nosupport-webrtc branch November 18, 2020 23:27
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 19, 2020

This PR shares problems around page removals/redirects like some of the other recent feature removal PRs. I was going to start cleaning the pages up, but on closer examination, I think the data is not trustworthy enough to merit removal on its own (e.g., https://chromestatus.com/feature/5085886951718912 shows at least some of the RTCIceTransport API is supported in Chrome; the current data is all false).

I'm going to revert this, but if you want to reopen this as a new PR or issue and explore the data here more thoroughly, that would be fine. I'm not rejecting this PR so much as declaring it premature.

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Nov 19, 2020
ddbeck added a commit that referenced this pull request Nov 19, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 19, 2020

Reverted with #7414.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants