Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove never-supported WebXR APIs #6943

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Remove never-supported WebXR APIs #6943

merged 1 commit into from
Nov 18, 2020

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 16, 2020
queengooborg
queengooborg approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good, plus XRPermissionDescriptor is a dictionary!

@queengooborg queengooborg merged commit cb1d7a2 into mdn:master Nov 18, 2020
@saschanaz saschanaz deleted the nosupport-webxr branch November 18, 2020 23:28
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Nov 19, 2020
@ddbeck
Revert "Remove never-supported WebXR APIs (mdn#6943)"
e231268 
The original removals are a bit complicated. The APIs that use the
dictionaries are supported, so it's a bit messy to remove these without
breaking the MDN docs for those APIs. Plus they're still in the
specification, so I think it merits more investigation about how to
remove this data.

This reverts commit cb1d7a2.
@ddbeck ddbeck mentioned this pull request Nov 19, 2020
Merged
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 19, 2020

I'm reverting this with #7412. Merging this removal seems premature for a few reasons (and we never did the content cleanup, even if this was the right thing to do).

ddbeck added a commit that referenced this pull request Nov 19, 2020
@ddbeck
Revert "Remove never-supported WebXR APIs (#6943)" (#7412)
efb87bc 
The original removals are a bit complicated. The APIs that use the
dictionaries are supported, so it's a bit messy to remove these without
breaking the MDN docs for those APIs. Plus they're still in the
specification, so I think it merits more investigation about how to
remove this data.

This reverts commit cb1d7a2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschanaz @ddbeck @queengooborg