Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Safari data for HTML element APIs (for Safari 5 to 6.1) #7290

Merged

Conversation

queengooborg
Copy link
Contributor

This PR corrects the Safari data for the HTML element APIs based upon results from the mdn-bcd-collector project (using results from Safari 3-14), including mirroring to Safari iOS. This particular PR is a cherry-pick for all the changes that set it to Safari 5 to 6.1.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 5, 2020
@queengooborg queengooborg force-pushed the api/HTMLElement-safari/corrections-5-6.1 branch from 45e08ee to b419724 Compare November 5, 2020 13:23
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass I've focused on what I see with npm run diff ../bcd-lhs/ ../bcd-rhs/ -- --filter.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed using my npm run diff prototype, the set of changes together seem sensible, nothing about it raises red flags for me.

@foolip foolip merged commit ec7f198 into mdn:master Nov 6, 2020
@queengooborg queengooborg deleted the api/HTMLElement-safari/corrections-5-6.1 branch November 6, 2020 12:39
foolip added a commit to foolip/browser-compat-data that referenced this pull request Jul 19, 2024
This was implemented without a flag, and with the reflected IDL
attribute, in WebKit 532.6:
WebKit/WebKit@c205c4e
https://github.com/WebKit/WebKit/blob/c205c4e7d40da38c5009df548c2316a358a4fca7/WebCore/Configurations/Version.xcconfig

That maps to Chrome 5 + Safari 5 + iOS 4, which also matches exactly
earlier updates based on collector test results:
mdn#7243
mdn#7290
mdn#7402

The handled attribute tokens were "allow-same-origin", "allow-forms",
and "allow-scripts", so update that data to match.
foolip added a commit to foolip/browser-compat-data that referenced this pull request Jul 19, 2024
This was implemented without a flag, and with the reflected IDL
attribute, in WebKit 532.6:
WebKit/WebKit@c205c4e
https://github.com/WebKit/WebKit/blob/c205c4e7d40da38c5009df548c2316a358a4fca7/WebCore/Configurations/Version.xcconfig

That maps to Chrome 5 + Safari 5 + iOS 4, which also matches exactly
earlier updates based on collector test results:
mdn#7243
mdn#7290
mdn#7402

The handled attribute tokens were "allow-same-origin", "allow-forms",
and "allow-scripts", so update that data to match.

The "allow-popups" entry was bumped to pass the lint.
Elchi3 pushed a commit that referenced this pull request Jul 22, 2024
This was implemented without a flag, and with the reflected IDL
attribute, in WebKit 532.6:
WebKit/WebKit@c205c4e
https://github.com/WebKit/WebKit/blob/c205c4e7d40da38c5009df548c2316a358a4fca7/WebCore/Configurations/Version.xcconfig

That maps to Chrome 5 + Safari 5 + iOS 4, which also matches exactly
earlier updates based on collector test results:
#7243
#7290
#7402

The handled attribute tokens were "allow-same-origin", "allow-forms",
and "allow-scripts", so update that data to match.

The "allow-popups" entry was bumped to pass the lint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants