-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct Safari data for HTML element APIs (for Safari 5 to 6.1) #7290
Correct Safari data for HTML element APIs (for Safari 5 to 6.1) #7290
Conversation
45e08ee
to
b419724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass I've focused on what I see with npm run diff ../bcd-lhs/ ../bcd-rhs/ -- --filter
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed using my npm run diff
prototype, the set of changes together seem sensible, nothing about it raises red flags for me.
This was implemented without a flag, and with the reflected IDL attribute, in WebKit 532.6: WebKit/WebKit@c205c4e https://github.com/WebKit/WebKit/blob/c205c4e7d40da38c5009df548c2316a358a4fca7/WebCore/Configurations/Version.xcconfig That maps to Chrome 5 + Safari 5 + iOS 4, which also matches exactly earlier updates based on collector test results: mdn#7243 mdn#7290 mdn#7402 The handled attribute tokens were "allow-same-origin", "allow-forms", and "allow-scripts", so update that data to match.
This was implemented without a flag, and with the reflected IDL attribute, in WebKit 532.6: WebKit/WebKit@c205c4e https://github.com/WebKit/WebKit/blob/c205c4e7d40da38c5009df548c2316a358a4fca7/WebCore/Configurations/Version.xcconfig That maps to Chrome 5 + Safari 5 + iOS 4, which also matches exactly earlier updates based on collector test results: mdn#7243 mdn#7290 mdn#7402 The handled attribute tokens were "allow-same-origin", "allow-forms", and "allow-scripts", so update that data to match. The "allow-popups" entry was bumped to pass the lint.
This was implemented without a flag, and with the reflected IDL attribute, in WebKit 532.6: WebKit/WebKit@c205c4e https://github.com/WebKit/WebKit/blob/c205c4e7d40da38c5009df548c2316a358a4fca7/WebCore/Configurations/Version.xcconfig That maps to Chrome 5 + Safari 5 + iOS 4, which also matches exactly earlier updates based on collector test results: #7243 #7290 #7402 The handled attribute tokens were "allow-same-origin", "allow-forms", and "allow-scripts", so update that data to match. The "allow-popups" entry was bumped to pass the lint.
This PR corrects the Safari data for the HTML element APIs based upon results from the mdn-bcd-collector project (using results from Safari 3-14), including mirroring to Safari iOS. This particular PR is a cherry-pick for all the changes that set it to Safari 5 to 6.1.