Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Firefox versions for MediaError API #7963

Closed
wants to merge 1 commit into from
Closed

Update Firefox versions for MediaError API #7963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions api/MediaError.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
"version_added": "12"
},
"firefox": {
"version_added": "3.5"
"version_added": "4"
Copy link
Contributor

@foolip foolip Dec 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original "3.5" matches the data for api.HTMLMediaElement.error which is an instance of MediaError. This is most likely an interface object not exposed. Can you check this manually?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8806 in Firefox 3.6 on BrowserStack and video.error is there. To make sure it wasn't just always null I checked when it was added and as part of that came across https://bugzilla.mozilla.org/show_bug.cgi?id=589561#c4. MediaError was originally HTMLMediaError and TimeRanges was HTMLTimeRanges.

I've sent #8734 to fix this.

},
"firefox_android": {
"version_added": true
"version_added": "4"
},
"ie": {
"version_added": "9"
Expand Down Expand Up @@ -61,10 +61,10 @@
"version_added": "12"
},
"firefox": {
"version_added": "3.5"
"version_added": "4"
},
"firefox_android": {
"version_added": true
"version_added": "4"
},
"ie": {
"version_added": "9"
Expand Down