Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAPI] Implement navigator.pdfViewerEnabled #13370

Closed
6 of 7 tasks
Rumyra opened this issue Mar 1, 2022 · 2 comments
Closed
6 of 7 tasks

[WebAPI] Implement navigator.pdfViewerEnabled #13370

Rumyra opened this issue Mar 1, 2022 · 2 comments
Assignees
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Mar 1, 2022

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
    or
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

Implement navigator.pdfViewerEnabled / hard-coded navigator.plugins + navigator.mimeTypes

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1720353

Other

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 1, 2022
@Rumyra Rumyra removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 1, 2022
@hamishwillee hamishwillee self-assigned this Mar 4, 2022
@hamishwillee
Copy link
Collaborator

hamishwillee commented Mar 4, 2022

For FF this updates spec to implement behaviour described in https://html.spec.whatwg.org/multipage/system-state.html#pdf-viewing-support.

In essence people were using a deprecated API to find work out whether inline PDF display was working based on the supported mime types and a small number of plugins they trusted. This was unreliable, and provided a fingerprinting surface. So this change provides a new API to just query whether it is supported or not, and also updates the old API so it returns the same information for all browser (i.e. no fingerprinting) and this matches what sites are normally using to determine inline browsing support.

The new property is navigator.pdfViewerEnabled. It is in BCD because was added in Chrome 94. Info about this and other platforms here. It is not documented.

The deprecated properties are Navigator.mimeTypes and Navigator.plugins . These exist but need work.

I am confirming the above in https://bugzilla.mozilla.org/show_bug.cgi?id=1720353#c18

@hamishwillee
Copy link
Collaborator

hamishwillee commented Mar 7, 2022

@Rumyra Rumyra closed this as completed Mar 21, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 99 labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
None yet
Development

No branches or pull requests

3 participants