-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigator.plugins, mimeTypes, pdfViewerEnabled updates #13605
Conversation
Co-authored-by: Joe Medley <jmedley@google.com>
Thanks @jpmedley - I've accepted all your suggestions (with answers to questions embedded, where relevant). Ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies. This is needed to make one of the tests pass.
Co-authored-by: Joe Medley <jmedley@google.com>
Not your fault. The filename was upper cased. Fixed now. |
Preview URLs
FlawsURL:
URL:
URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs |
This is first part of work for https://bugzilla.mozilla.org/show_bug.cgi?id=1720353
This adds docs for
Navigator.pdfViewerEnabled
, which is the new say to test whether inline viewing of PDF files is supported when you click on a PDF file link.In addition there are some deprecated properties
Navigator.plugins
andNavigator.mimeTypes
that were/are used by sites to feature test for PDF viewer support. However the method is unreliable, because they tend to check only a couple of plugins, and also gives out some info that can be used for fingerprinting. So the spec also hard codes the output to be some of the strings that the old code typically uses for feature checking IFF PDF viewing is supported, or nothing if it is not - ie it mirrors the new property in the old properties.This is no great loss since this is about all they were being use for other than flash, which is also highly discommended.
Other docs work can be tracked in #13370