Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator.plugins, mimeTypes, pdfViewerEnabled updates #13605

Merged
merged 5 commits into from
Mar 15, 2022

Conversation

hamishwillee
Copy link
Collaborator

This is first part of work for https://bugzilla.mozilla.org/show_bug.cgi?id=1720353

This adds docs for Navigator.pdfViewerEnabled, which is the new say to test whether inline viewing of PDF files is supported when you click on a PDF file link.

In addition there are some deprecated properties Navigator.plugins and Navigator.mimeTypes that were/are used by sites to feature test for PDF viewer support. However the method is unreliable, because they tend to check only a couple of plugins, and also gives out some info that can be used for fingerprinting. So the spec also hard codes the output to be some of the strings that the old code typically uses for feature checking IFF PDF viewing is supported, or nothing if it is not - ie it mirrors the new property in the old properties.
This is no great loss since this is about all they were being use for other than flash, which is also highly discommended.

Other docs work can be tracked in #13370

@hamishwillee hamishwillee requested a review from a team as a code owner March 7, 2022 06:41
@hamishwillee hamishwillee requested review from jpmedley and removed request for a team March 7, 2022 06:41
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 7, 2022
files/en-us/web/api/navigator/mimetypes/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/navigator/mimetypes/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/navigator/mimetypes/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/navigator/mimetypes/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/navigator/pdfViewerEnabled/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/navigator/plugins/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/navigator/plugins/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/navigator/plugins/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/navigator/plugins/index.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Medley <jmedley@google.com>
@hamishwillee hamishwillee requested a review from jpmedley March 7, 2022 21:59
@hamishwillee
Copy link
Collaborator Author

Thanks @jpmedley - I've accepted all your suggestions (with answers to questions embedded, where relevant). Ready for re-review.

Copy link
Collaborator

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. This is needed to make one of the tests pass.

files/en-us/web/api/navigator/pdfViewerEnabled/index.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Medley <jmedley@google.com>
@hamishwillee hamishwillee dismissed jpmedley’s stale review March 11, 2022 02:16

Merged the requested change

@hamishwillee
Copy link
Collaborator Author

Not your fault. The filename was upper cased. Fixed now.

@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Navigator
Title: Navigator
on GitHub
Flaw count: 5

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Navigator/securitypolicy does not exist
    • /en-US/docs/Web/API/Navigator/standalone does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/Navigator/mimeTypes
Title: Navigator.mimeTypes
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/Navigator/plugins
Title: Navigator.plugins
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/Navigator/pdfViewerEnabled
Title: Navigator.pdfViewerEnabled
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/API/Navigator
Title: Navigator
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Navigator/mimeTypes
Title: Navigator.mimeTypes
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Navigator/plugins
Title: Navigator.plugins
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Navigator/pdfViewerEnabled
Title: Navigator.pdfViewerEnabled
on GitHub

No new external URLs

@hamishwillee
Copy link
Collaborator Author

@jpmedley I think the updates I made here cleared your approval.

@jpmedley jpmedley merged commit c1d3f3d into mdn:main Mar 15, 2022
@hamishwillee hamishwillee deleted the ff98_nav_pdf branch March 15, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants