Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec URLs for web/accessibility subtree #13170

Merged
merged 2 commits into from
May 14, 2022

Conversation

sideshowbarker
Copy link
Collaborator

Part of #13126

@sideshowbarker sideshowbarker requested a review from a team as a code owner February 21, 2022 06:48
@sideshowbarker sideshowbarker requested review from estelle and removed request for a team February 21, 2022 06:48
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Feb 21, 2022
@github-actions

This comment was marked as resolved.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I'm waiting for the answer to my question to merge it.

@sideshowbarker
Copy link
Collaborator Author

This is now just blocked on mdn/yari#5314

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/spec-urls-web/accessibility branch 2 times, most recently from 8b2d37c to 6ace784 Compare February 28, 2022 09:13
@estelle
Copy link
Member

estelle commented Mar 10, 2022

the conflicted pages are complete rewrites of the page. merging this will create a conflict in almost all these PRs: https://github.com/mdn/content/pulls?q=is%3Apr+is%3Aopen+label%3AContent%3AAccessibility

@sideshowbarker
Copy link
Collaborator Author

the conflicted pages are complete rewrites of the page. merging this will create a conflict in almost all these PRs: https://github.com/mdn/content/pulls?q=is%3Apr+is%3Aopen+label%3AContent%3AAccessibility

OK, I can rebase it and resolve the merge conflicts

@Elchi3 Elchi3 removed their request for review March 21, 2022 15:43
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/spec-urls-web/accessibility branch from 6ace784 to d047a8d Compare May 12, 2022 07:11
@sideshowbarker sideshowbarker marked this pull request as ready for review May 12, 2022 07:12
@sideshowbarker sideshowbarker requested review from a team and Guyzeroth and removed request for a team May 12, 2022 07:12
@sideshowbarker
Copy link
Collaborator Author

@estelle This one’s now ready for re-review

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/spec-urls-web/accessibility branch from d047a8d to 606e245 Compare May 12, 2022 08:00
Otherwise, without this change, the spec-urls values being added for the
ARIA Authoring Practices guide get shown with “Unknown specification” in
output.
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/spec-urls-web/accessibility branch from 606e245 to 90a4b86 Compare May 14, 2022 08:12
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@queengooborg queengooborg merged commit 9cae616 into main May 14, 2022
@queengooborg queengooborg deleted the sideshowbarker/spec-urls-web/accessibility branch May 14, 2022 09:14
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request May 23, 2022
* Add spec URLs for web/accessibility subtree

Part of mdn#13126

* Add the Living version of ARIA Authoring Practices to SpecData.json

Otherwise, without this change, the spec-urls values being added for the
ARIA Authoring Practices guide get shown with “Unknown specification” in
output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants