-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec URLs for web/accessibility subtree #13170
Add spec URLs for web/accessibility subtree #13170
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
files/en-us/web/accessibility/aria/attributes/aria-activedescendant/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but I'm waiting for the answer to my question to merge it.
files/en-us/web/accessibility/aria/roles/structure_role/index.md
Outdated
Show resolved
Hide resolved
085367e
to
95ddae5
Compare
This is now just blocked on mdn/yari#5314 |
8b2d37c
to
6ace784
Compare
the conflicted pages are complete rewrites of the page. merging this will create a conflict in almost all these PRs: https://github.com/mdn/content/pulls?q=is%3Apr+is%3Aopen+label%3AContent%3AAccessibility |
OK, I can rebase it and resolve the merge conflicts |
6ace784
to
d047a8d
Compare
@estelle This one’s now ready for re-review |
d047a8d
to
606e245
Compare
files/en-us/web/accessibility/aria/attributes/aria-activedescendant/index.md
Outdated
Show resolved
Hide resolved
Otherwise, without this change, the spec-urls values being added for the ARIA Authoring Practices guide get shown with “Unknown specification” in output.
606e245
to
90a4b86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
* Add spec URLs for web/accessibility subtree Part of mdn#13126 * Add the Living version of ARIA Authoring Practices to SpecData.json Otherwise, without this change, the spec-urls values being added for the ARIA Authoring Practices guide get shown with “Unknown specification” in output.
Part of #13126