Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec URLs for web/api subtree #13198

Merged
merged 4 commits into from
May 13, 2022
Merged

Add spec URLs for web/api subtree #13198

merged 4 commits into from
May 13, 2022

Conversation

sideshowbarker
Copy link
Member

Part of #13126

@sideshowbarker sideshowbarker requested a review from a team as a code owner February 22, 2022 02:45
@sideshowbarker sideshowbarker requested review from wbamberg and removed request for a team February 22, 2022 02:45
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 22, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@sideshowbarker sideshowbarker marked this pull request as draft February 23, 2022 00:22
@sideshowbarker
Copy link
Member Author

This is now just blocked on mdn/yari#5314

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/spec-urls-web/api branch 3 times, most recently from 67a70d5 to fddc982 Compare February 28, 2022 08:36
@queengooborg
Copy link
Collaborator

It looks like the PR that was blocking this has been merged -- would you like to give this a rebase @sideshowbarker?

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/spec-urls-web/api branch 2 times, most recently from 95c54c7 to 21e8806 Compare May 13, 2022 07:41
@sideshowbarker sideshowbarker marked this pull request as ready for review May 13, 2022 07:44
@sideshowbarker
Copy link
Member Author

It looks like the PR that was blocking this has been merged -- would you like to give this a rebase @sideshowbarker?

Yup, thanks for the heads-up — now rebased

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/spec-urls-web/api branch from 21e8806 to 5c1be5e Compare May 13, 2022 07:46
queengooborg
queengooborg reviewed May 13, 2022
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing! Just got a couple of questions regarding some of the other changes in this PR:

files/en-us/web/api/aescbcparams/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/css_object_model/css_declaration/index.md Show resolved Hide resolved
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/spec-urls-web/api branch from 5c1be5e to 3d62b99 Compare May 13, 2022 07:53
@queengooborg queengooborg self-requested a review May 13, 2022 07:56
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/spec-urls-web/api branch from 3d62b99 to c4be323 Compare May 13, 2022 08:03
queengooborg
queengooborg requested changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Just got a couple of suggestions for synchronizing with BCD (feel free to defer the {{Compat}} macro changes to a separate PR):

files/en-us/web/api/cryptokeypair/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/rootelement/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/rootelement/index.md Show resolved Hide resolved
files/en-us/web/api/gamepad_api/using_the_gamepad_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/gamepad_api/using_the_gamepad_api/index.md Show resolved Hide resolved
files/en-us/web/api/inputdevicecapabilities_api/index.md Show resolved Hide resolved
files/en-us/web/api/mediastream_recording_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/mediastream_recording_api/index.md Show resolved Hide resolved
files/en-us/web/api/mediastream_recording_api/using_the_mediastream_recording_api/index.md Show resolved Hide resolved
files/en-us/web/api/mediastream_recording_api/using_the_mediastream_recording_api/index.md Outdated Show resolved Hide resolved
sideshowbarker and others added 3 commits May 13, 2022 17:36
@sideshowbarker @queengooborg
Apply suggestions from code review
d07dcb4 
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
@sideshowbarker
Revert change to EyeDropper API doc
63f0663 
This should be using browser-compat rather than spec-urls
@sideshowbarker
Simply Compat macro calls redundant with browser-compat values
59a2857
queengooborg
queengooborg approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes, LGTM!

@queengooborg queengooborg merged commit a39becf into main May 13, 2022
@queengooborg queengooborg deleted the sideshowbarker/spec-urls-web/api branch May 13, 2022 08:54
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request May 23, 2022
@sideshowbarker @hamishwillee
Add spec URLs for web/api subtree (mdn#13198)
4ede90d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sideshowbarker @queengooborg