-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec URLs for the web/svg subtree #13265
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so great to see all these HTML tables gone.
My only concern here is that some of these pages have BCD, but the BCD is missing spec URLs, so the pages are losing spec tables in the transition.
We could just file a bug against BCD listing all pages that need spec URLs, and the URLs they need, scraped out of these pages? I'd be happy to help add them.
I went ahead and opened PR mdn/browser-compat-data#15114 for that, with patch.
Thanks for having caught that. I had a bug/oversight in the code I wrote to add the There turned out to be 60 cases where a specified BCD feature didn’t have a 37 of those features are specified in the SVG2 spec or another current spec. I’m personally not super-enthusiastic about us going out of our way to maintain data on features that never actually got implemented in any browsers. I’d be happier to see them removed from BCD completely, and for the MDN articles to disappear too. But anyway, the mdn/browser-compat-data#15114 patch does add the |
Along with the cases where we had BCD data for a feature but that data was missing a Maybe those are features that should exist in BCD or maybe they shouldn’t — or maybe they were intentionally removed. Regardless, I don’t think we should block this PR on getting those features added to BCD, because it’s a much bigger deal to add all the data for a feature to BCD — we’d need to investigate the browser support for it, and add all the browser-version data (not just the Somebody should ideally do that eventually (I’m not volunteering) but I suggest that for now now we just go ahead and add the So I pushed 39c9688 with a change that adds the |
The problem of web/svg is that we have pages about attributes at a global level and the attributes are defined on several SVG elements. I'm not sure we want a page per attribute, but if so, we should have the attribute pages below their element. Right now there is no correspondence between what is in bcd (and that is incomplete) and pages on content. But fixing this means completing/updating the web/svg docs. That's a huge amount of work and probably not the top priority as most people are using tools to generate svg files. |
Yeah, there are some bigger problems with the SVG docs, but I think it’s a win when we can at least just make them a little better (in this case by getting rid of the manual specification tables — especially the HTML tables that the svg subtree seemed to have a lot of). |
Thank you!
Yes, I agree, but that seems like scope creep for this PR.
Yes, I agree that this is the right thing to do. |
39c9688
to
18896dd
Compare
18896dd
to
7154f0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is LGTM!
* Add spec URLs for the web/svg subtree Part of mdn#13126 * Drop browser-compat for SVG cases not actually in BCD; add spec-urls instead * Fix browser-compat for “by”, “spreadMethod” & “vector-effect” Related: mdn/browser-compat-data#15141
Part of #13126. Many of these documents already had a browser-compat key — and thus didn’t need a spec-urls key. So in those cases, this change just replaces the manual specifications table with a
{{Specifications}}
macro.