-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace macros Bug and WebkitBug by regular MD links #24834
Conversation
@@ -42,7 +42,7 @@ Some syntax, like the one of {{HTTPHeader("Accept")}}, allow additional specifie | |||
|
|||
### Firefox | |||
|
|||
Starting with Firefox 18, the quality factor values are clamped to 2 decimal places. They used to be clamped to only 1 decimal place in earlier versions ({{bug(672448)}}). | |||
Starting with Firefox 18, the quality factor values are clamped to 2 decimal places. They used to be clamped to only 1 decimal place in earlier versions ([Firefox bug 672448](https://bugzilla.mozilla.org/show_bug.cgi?id=672448)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use the shortlinks instead, i.e. https://bugzil.la
?
Starting with Firefox 18, the quality factor values are clamped to 2 decimal places. They used to be clamped to only 1 decimal place in earlier versions ([Firefox bug 672448](https://bugzilla.mozilla.org/show_bug.cgi?id=672448)). | |
Starting with Firefox 18, the quality factor values are clamped to 2 decimal places. They used to be clamped to only 1 decimal place in earlier versions ([Firefox bug 672448](https://bugzil.la/672448)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bugzil.la, webkit.org/b and crbug.com are shorter and thus, much easier to read (which helps contributors). I don't know about MDN as a whole, but BCD has a policy in place to use shortlinks for bug links. (Maybe someone can confirm if there is an MDN-wide policy for these cases.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't but I have no problem using them. No reason to do differently.
Let me fix this
Fixed. Note that as we don't have linting on this, this will diverge; I don't think it is a problem, though. |
@@ -165,10 +165,10 @@ Most macros will also take a second argument allowing you to change the display | |||
|
|||
- Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should actually remove this entire section; it's talking strictly about the bug macros which will be removed soon!
This pull request has merge conflicts that must be resolved before it can be merged. |
In mdn#24834, some Firefox bug links were accidentally labeled as "Webkit bug".
In #24834, some Firefox bug links were accidentally labeled as "Webkit bug".
Content counterpart of mdn/yari#8298