-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'How to add tags' page #25131
Conversation
This fixes the last content bit of mdn/mdn#262 |
We need to remove links to the page as well:
|
Good point. My brain malfunctioned and believed there would be no links to it… This is obviously not the case. |
The onus shouldn't be put on contributors to remember these auto detectable things. It would be better if the PR check workflow, for every deleted document in the PR, grep(rg) entire content for links( Or may be the document deletion script, after deletion, warn/log document containing references to the deleted document. |
I think that Even if it doesn't work for links generated by macros, it will already solve many cases. |
The fact is, even if you add a redirect, that does not clean up the content around the page link. The redirect should really only be to fix up external links to the page, for which we have no control. I'm sure we all agree with that, and the need to clean up content when deleting/redirecting. Sadly, I once proposed that deleting or moving a page should list the linked pages. That got closed by (as I recall) a warning added when you delete or redirect a page that you might need to do cleanup. We could request this in yari again. Thanks very much for making this fix @teoli2003 !!! |
PS I think it might be worth having a single page covering page metadata, and sticking as much of our page metadata instructions elsewhere into that. |
Now that tags are gone, this page is no more useful.