Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new design system links #25486

Merged
merged 6 commits into from
Mar 23, 2023
Merged

Add new design system links #25486

merged 6 commits into from
Mar 23, 2023

Conversation

dawei-wang
Copy link
Contributor

@dawei-wang dawei-wang commented Mar 20, 2023 •
edited
Loading

Fixed two links that pointed to the same page. Updates the links to point to relevant pages in the Acorn design system.
Fix #20860

Description

Motivation

Additional details

Related issues and pull requests

@dawei-wang
Add new design system links
7463ce0 
Fixed two links that pointed to the same page. Updates the links to point to relevant pages in the Acorn design system.
Fix mdn#20860
@dawei-wang dawei-wang requested a review from a team as a code owner March 20, 2023 18:39
@dawei-wang dawei-wang requested review from rebloor and removed request for a team March 20, 2023 18:39
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs labels Mar 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023 •
edited
Loading

Preview URLs (10 pages)
External URLs (15)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Sidebars
Title: Sidebars

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Notifications
Title: Notifications

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Context_menu_items
Title: Context menu items

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Options_pages
Title: Options page

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Page_actions
Title: Address bar button

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/devtools_panels
Title: devtools panels

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups
Title: Popups

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Extension_pages
Title: Extension pages

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_action
Title: Toolbar button

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/options_ui
Title: options_ui

(comment last updated: 2023-03-23 01:40:18)

@rebloor
Copy link
Contributor

rebloor commented Mar 22, 2023

@dawei-wang would you consider fixing the other out-of-date links in:

  • files/en-us/mozilla/add-ons/webextensions/manifest.json/options_ui/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/context_menu_items/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/devtools_panels/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/extension_pages/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/notifications/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/options_pages/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/page_actions/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/popups/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/sidebars/index.md

@dawei-wang
Copy link
Contributor Author

@dawei-wang would you consider fixing the other out-of-date links in:

  • files/en-us/mozilla/add-ons/webextensions/manifest.json/options_ui/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/context_menu_items/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/devtools_panels/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/extension_pages/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/notifications/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/options_pages/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/page_actions/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/popups/index.md
  • files/en-us/mozilla/add-ons/webextensions/user_interface/sidebars/index.md

Sure!

@dawei-wang dawei-wang marked this pull request as draft March 22, 2023 17:57
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:JS JavaScript docs Content:Learn Learning area docs Content:WebAPI Web API docs labels Mar 22, 2023
@dawei-wang dawei-wang marked this pull request as ready for review March 22, 2023 20:05
@dawei-wang dawei-wang requested review from schalkneethling and a team as code owners March 22, 2023 20:05
@dawei-wang dawei-wang removed the request for review from a team March 22, 2023 20:05
@dawei-wang dawei-wang requested review from sideshowbarker, teoli2003, estelle and bsmth and removed request for a team March 22, 2023 20:05
@github-actions github-actions bot removed Content:WebAPI Web API docs Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Glossary Glossary entries Content:JS JavaScript docs Content:Learn Learning area docs Content:CSS Cascading Style Sheets docs labels Mar 22, 2023
@rebloor rebloor merged commit 1b1c7a6 into mdn:main Mar 23, 2023
@rebloor
Copy link
Contributor

rebloor commented Mar 23, 2023

@dawei-wang Thanks for fixing them all,

@dawei-wang dawei-wang deleted the patch-1 branch March 23, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebloor rebloor rebloor approved these changes

@schalkneethling schalkneethling Awaiting requested review from schalkneethling

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker was automatically assigned from mdn/yari-content-web-api

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 was automatically assigned from mdn/yari-content-http

@estelle estelle Awaiting requested review from estelle estelle was automatically assigned from mdn/yari-content-css

@bsmth bsmth Awaiting requested review from bsmth bsmth was automatically assigned from mdn/core-yari-content

Assignees
No one assigned
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference in browser extension documentation to obsolete "Iconography" page
2 participants
@dawei-wang @rebloor