Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add popover attributes/properties/methods/events #25961

Conversation

keithamus
Copy link
Contributor

Description

This adds the preliminary content for popover - it adds:

  • the popover property to the HTMLElement properties list
  • the showPopover, hidePopover, togglePopover methods to the HTMLElement methods list
  • the toggle, beforetoggle events in the HTMLElement events list

Motivation

This will help as the foundations of documenting these features. I'm happy to continue this PR or make stacked PRs.

Additional details

Related issues and pull requests

#25125

@keithamus keithamus requested review from a team as code owners April 6, 2023 16:47
@keithamus keithamus requested review from wbamberg and schalkneethling and removed request for a team April 6, 2023 16:47
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs labels Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Preview URLs

Flaws (20)

URL: /en-US/docs/Web/HTML/Global_attributes
Title: Global attributes
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Global_attributes/popover
    • Can't resolve /en-US/docs/Web/HTML/button#popovertarget
    • Can't resolve /en-US/docs/Web/API/HTMLElement/showPopover/

URL: /en-US/docs/Web/API/HTMLElement
Title: HTMLElement
Flaw count: 17

  • macros:
    • /en-US/docs/Web/API/HTMLElement/attributeStyleMap does not exist
    • /en-US/docs/Web/API/HTMLElement/draggable does not exist
    • /en-US/docs/Web/API/HTMLElement/popover does not exist
    • /en-US/docs/Web/API/HTMLElement/noModule does not exist
    • /en-US/docs/Web/API/HTMLElement/properties does not exist
    • and 11 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Global_attributes/popover

@sideshowbarker sideshowbarker merged commit b3df2fc into mdn:main Apr 7, 2023
@sideshowbarker
Copy link
Member

Keith, thanks much, and congrats on landing your first docs change here — welcome aboard 🎉

@keithamus keithamus deleted the add-popover-attributes-properties-methods-events branch April 12, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants