Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL fragments #26471

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Fix URL fragments #26471

merged 3 commits into from
Apr 28, 2023

Conversation

OnkarRuikar
Copy link
Contributor

Fix some broken URL fragments

Note: also testing #26410

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner April 28, 2023 05:43
@OnkarRuikar OnkarRuikar requested review from estelle and removed request for a team April 28, 2023 05:43
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Apr 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023 •
edited
Loading

Preview URLs (9 pages)
Flaws (2)

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/cross-fade
Title: cross-fade()
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/_image redirects to /en-US/docs/Web/CSS/image/image
    • /en-US/docs/Web/CSS/image-set redirects to /en-US/docs/Web/CSS/image/image-set

(comment last updated: 2023-04-28 05:50:06)

@teoli2003
Copy link
Contributor

Yeah! The linter detected it!

Capture d’écran 2023-04-28 à 07 45 47

@OnkarRuikar
Copy link
Contributor Author

Yeah! The linter detected it!

I did try to commit with wrong values and husky didn't let me commit with wrong values. Then committed wrong order and indentation husky fixed it before the commit.

Only thing remains to test now is the cron job. For that do not merge #26441 today. Tomorrow we should get these changes in Daily markdownlint PR.

@teoli2003 teoli2003 merged commit 2a23f65 into mdn:main Apr 28, 2023
@OnkarRuikar OnkarRuikar deleted the fix_frags branch April 28, 2023 05:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @teoli2003