Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slugs and titles in CSS module landing pages (m - v plus misc) #26974

Merged
merged 7 commits into from
May 25, 2023
Merged

fix: slugs and titles in CSS module landing pages (m - v plus misc) #26974

merged 7 commits into from
May 25, 2023

Conversation

dipikabh
Copy link
Contributor

@dipikabh dipikabh commented May 25, 2023 •
edited
Loading

Description

This is the third in the series following #26939 (1).

This PR should be merged after #26958 (2). Some of the broken link flaws in this PR will get resolved after (2) is merged.

@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label May 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023 •
edited
Loading

Preview URLs (41 pages)
Flaws (9)

Note! 33 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_writing_modes
Title: CSS writing modes
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/glyph-orientation-horizontal does not exist

URL: /en-US/docs/Web/CSS/CSS_shapes/Shapes_from_images
Title: Shapes from images
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_images/Using_CSS_gradients

URL: /en-US/docs/Web/CSS/CSS_transitions/Using_CSS_transitions
Title: Using CSS transitions
Flaw count: 1

  • macros:
    • `/home/runner/work/content/content/node_modules/@mdn/yari/kumascript/macros/Specifications.ejs:1

1| <%
2| /*
3| Placeholder to render a specification section with spec_urls from BCD
4|

No first query argument or 'browser-compat' or 'spec-urls' front-matter value passed`

URL: /en-US/docs/Web/CSS/CSS_multicol_layout
Title: CSS multi-column layout
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_paged_media
    • Can't resolve /en-US/docs/Web/CSS/CSS_grid_layout

URL: /en-US/docs/Web/CSS/CSS_multicol_layout/Basic_concepts
Title: Basic concepts of multi-column layout
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_paged_media

URL: /en-US/docs/Web/CSS/CSS_multicol_layout/Styling_columns
Title: Styling columns
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_grid_layout/Box_alignment_in_grid_layout

URL: /en-US/docs/Web/CSS/CSS_multicol_layout/Spanning_balancing_columns
Title: Spanning and balancing columns
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_paged_media

URL: /en-US/docs/Web/CSS/CSS_color_adjustment
Title: CSS color adjustment
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/color-adjust redirects to /en-US/docs/Web/CSS/print-color-adjust
External URLs (1)

URL: /en-US/docs/Web/CSS/CSS_shapes
Title: CSS shapes

(comment last updated: 2023-05-25 23:21:20)

@dipikabh dipikabh mentioned this pull request May 25, 2023
Merged
@dipikabh dipikabh marked this pull request as ready for review May 25, 2023 23:09
@dipikabh dipikabh requested review from a team as code owners May 25, 2023 23:09
@dipikabh dipikabh requested review from chrisdavidmills, estelle and teoli2003 and removed request for a team May 25, 2023 23:09
estelle
estelle approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fun ;)

@estelle estelle merged commit e1b6d7d into mdn:main May 25, 2023
yin1999 added a commit to mdn/translated-content that referenced this pull request May 26, 2023
@yin1999
fix: slugs and titles in CSS module landing pages (m - v plus misc)
ed5df83 
ref: mdn/content#26974
yin1999 added a commit to mdn/translated-content that referenced this pull request May 26, 2023
@mdn-bot @yin1999
[zh-tw] sync translated content (#13400)
5c6f6b8 
* zh-tw: sync translated content

* fix: slugs and titles in CSS module landing pages (m - v plus misc)

ref: mdn/content#26974

---------

Co-authored-by: Allo <yin199909@aliyun.com>
yin1999 added a commit to mdn/translated-content that referenced this pull request May 26, 2023
@yin1999
fix: slugs and titles in CSS module landing pages (m - v plus misc)
06aaa6b 
ref: mdn/content#26974
yin1999 added a commit to mdn/translated-content that referenced this pull request May 26, 2023
@mdn-bot @yin1999
[zh-cn] sync translated content (#13401)
291c69d 
* zh-cn: sync translated content

* fix: slugs and titles in CSS module landing pages (m - v plus misc)

ref: mdn/content#26974

---------

Co-authored-by: Allo <yin199909@aliyun.com>
@dipikabh
Copy link
Contributor Author

Thanks Estelle!

@dipikabh dipikabh deleted the css-modland-slug-title-t branch May 26, 2023 13:35
@caugner caugner mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-css

@teoli2003 teoli2003 Awaiting requested review from teoli2003

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dipikabh @estelle