Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document abortable event listeners #2759

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Document abortable event listeners #2759

merged 4 commits into from
Mar 1, 2021

Commits on Feb 28, 2021

  1. Copy edits for “Introduction to events”

    @sideshowbarker
    sideshowbarker committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    a1d273b View commit details
    Browse the repository at this point in the history

  2. Push “fix fixable flaws” for removeEventListener()

    @sideshowbarker
    sideshowbarker committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    9bf73ff View commit details
    Browse the repository at this point in the history

  3. Drop link to non-standard/undocumented detachEvent

    @sideshowbarker
    sideshowbarker committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    f3b4a9b View commit details
    Browse the repository at this point in the history

  4. Document abortable event listeners 

    This patch includes the following changes:

- Document the "signal" parameter for the addEventListener() options object
- “Add an abortable listener” example code added to addEventListener() article
- Add a similar simple example code to he “Introduction to events” guide
- In both “Introduction to events” guide and removeEventListener() article,
  add prose mentions that you can pass an AbortSignal to an addEventListener()
  call, and abort/cancel/remove the listener by calling abort() on the
  controller owning the AbortSignal.

Related:

- whatwg/dom@83037a1
- https://dom.spec.whatwg.org/#dictdef-addeventlisteneroptions
- https://dom.spec.whatwg.org/#ref-for-concept-event-listener①
- https://dom.spec.whatwg.org/#ref-for-abortsignal③
    @sideshowbarker
    sideshowbarker committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    8e31499 View commit details
    Browse the repository at this point in the history