Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add content for overlay and discrete animation features #29049

Closed

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Sep 11, 2023

Note: This technical review is now completed and approved. For the follow-on editorial review, see #29943.


Description

This PR adds content for multiple related features that go together to enable the creation of exit/entrance animations using simple CSS, or to put it another way, animating to/from display: none (this includes top layer elements like popovers), or animating elements when they have just been added to the DOM.

Specifically, these are:

See my research document for more details of what this project aims to add.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested review from a team as code owners September 11, 2023 15:55
@chrisdavidmills chrisdavidmills requested review from wbamberg and dipikabh and removed request for a team September 11, 2023 15:55
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs labels Sep 11, 2023
@chrisdavidmills chrisdavidmills marked this pull request as draft September 11, 2023 15:56
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Preview URLs (12 pages)
Flaws (2)

Note! 11 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/@starting-style
Title: @starting-style
Flaw count: 2

  • broken_links:
    • No need for the pathname in anchor links if it's the same page
    • Link points to the page it's already on
External URLs (3)

URL: /en-US/docs/Web/CSS/transition-behavior
Title: transition-behavior


URL: /en-US/docs/Web/CSS/overlay
Title: overlay


URL: /en-US/docs/Web/CSS/@starting-style
Title: @starting-style

(comment last updated: 2023-10-31 17:01:36)

@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Sep 13, 2023
files/en-us/web/api/popover_api/using/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/popover_api/using/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/popover_api/using/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/popover_api/using/index.md Outdated Show resolved Hide resolved
@chrisdavidmills chrisdavidmills marked this pull request as ready for review September 27, 2023 15:40
@chrisdavidmills chrisdavidmills requested a review from a team as a code owner September 27, 2023 15:40
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Oct 10, 2023
@chrisdavidmills
Copy link
Contributor Author

This PR has been dormant for a while, but it has been reviewed (thanks @josepharhar!), and the content looks good. I am going to call the technical review completed. The next stage is to close this PR and open a new editorial review PR based on the same branch, which I'll pass to one of the MDN editorial team for final review before publication.

Copy link
Contributor Author

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I noticed. I'll fix it when I look at this again tomorrow.

files/en-us/web/css/@starting-style/index.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants