Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Editorial review: Add content for overlay and discrete animation features #29943
feat: Editorial review: Add content for overlay and discrete animation features #29943
Changes from 7 commits
0c09617
25f6a67
8cc056f
8fdd02c
31142db
44363dd
3e5bd55
39f6bb2
cc7e120
d9365ad
b6368b0
012fad4
0296fb0
48ae18f
d8727bb
e83cce9
41105a8
b289c4a
506100e
e2937ee
1be535b
657a296
d8169d1
c0bb544
b461119
465deb6
0aee741
a451388
4023e96
086c494
beb0532
74cea43
6bc44bf
44c146e
9609659
197b3d9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's important to delineate that every time it opens it goes to start-style, not just the first time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that we need to make this clear. I've added these notes in appropriate places.
I've also added an explanatory section and an example to the
@starting-style
page to explain and demonstrate the behavior. I've linked the notes in other places to the example so it can be seen in action.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The display none is not actually required as that is the browser default value for a closed popover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, but as mentioned previously, I think it is easier to understand the keyframes if you are more explicit and leave the start and end value in. So I'd like to leave this one as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add a note about it then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note added