-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(meta): Document Embedlivesample identifier #30102
Conversation
Preview URLs
External URLs (1)URL: (comment last updated: 2023-11-22 09:30:06) |
Thanks for opening this PR, @bsmth 🙏! I'll take a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bsmth. This is good overall. I've added some edit suggestions.
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
Thank you for the comments, @dipikabh! 🙏🏻 |
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
…s/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Thanks @dipikabh - let's take a look again when you're back. |
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, @bsmth. Thanks for the updates.
There's a few suggestions following Vadim's comment about saying "lang ID" vs "class". Leaving a +1 so you can merge after the changes.
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/live_samples/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Thanks, both. Going to merge now 🎉 |
The
{{Embedlivesample}}
macro currently has two ways of specifying which code blocks to combine into a "result" iframe, and only one of these ways is documented. This PR adds documentation for the "string identifier" method or marking fenced code blocks (HTML/CSS/JS) with an identifier in the info string using:```{language} live-sample___{identifier}
For example, in Markdown, this is used as follows: