Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove links to internal pages with broken tools #30647

Closed
wants to merge 1 commit into from

Conversation

estelle
Copy link
Member

@estelle estelle commented Nov 30, 2023

Remove links to tools that aren't currently working

@estelle estelle requested a review from wbamberg November 30, 2023 04:32
@estelle estelle requested a review from a team as a code owner November 30, 2023 04:32
@estelle estelle requested review from chrisdavidmills and removed request for a team November 30, 2023 04:32
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Nov 30, 2023
Copy link
Contributor

Preview URLs

Flaws (3)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_backgrounds_and_borders
Title: CSS backgrounds and borders
Flaw count: 3

  • macros:
    • /en-US/docs/Web/CSS/background-position-inline does not exist
    • /en-US/docs/Web/CSS/background-position-block does not exist
    • /en-US/docs/Web/CSS/line-type does not exist

@bsmth
Copy link
Member

bsmth commented Nov 30, 2023

What's the motivation to remove links to these?

@hamishwillee
Copy link
Collaborator

What's the motivation to remove links to these?

As @estelle says "links to tools that aren't currently working"

The with this is that it is hard to remember that you need to restore the links when the tools are working, and I wonder why they aren't working.

So personally I'd lean towards leaving the links but creating a clear warning on the linked page about the status of the tools.

@hamishwillee hamishwillee changed the title Remove links Remove links to internal pages with broken tools Dec 7, 2023
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle What is not working about these tools? I just tested them in Fx and Chrome, and they seemed to be working for me.

@bsmth bsmth added the awaiting response Awaiting for author to address review/feedback label Dec 20, 2023
@estelle estelle closed this Jan 3, 2024
@wbamberg
Copy link
Collaborator

wbamberg commented Jan 3, 2024

It depends what you mean by "not working". The layout/design of the tools has been broken ever since the MDN redesign in 2022, and there is a bug on file here: mdn/yari#5392 for that.

That issue links to several other issues that have been filed on mdn/content, which are basically duplicates.

Functionally the tools seem to work, although they've not had any updates for several years so don't support any syntax added since then. There is mdn/css-examples#157, which claims to be a functional issue but I think probably isn't (and if it isn't, should be closed as a duplicate of mdn/yari#5392).

However it's hard to argue that they are not a bad user experience for a professional site, to put things politely. Whether that's enough to stop linking to them, I don't know.

@estelle estelle deleted the tool_links branch January 9, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Awaiting for author to address review/feedback Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants