Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect statement about dialog top-layer placement #31866

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

chrisdavidmills
Copy link
Contributor

Description

This PR fixes an incorrect statement on the Popover API landing page ("bear in mind that elements are not put in the top layer by default").

Fixes #31757

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner January 23, 2024 15:40
@chrisdavidmills chrisdavidmills requested review from wbamberg and removed request for a team January 23, 2024 15:40
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Jan 23, 2024
Copy link
Contributor

github-actions bot commented Jan 23, 2024

Preview URLs

(comment last updated: 2024-01-23 15:43:48)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you Chris!

@wbamberg wbamberg merged commit f8730b4 into mdn:main Jan 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong or mistakable "<dialog> elements are not top-layer" statement in PopoverAPI introduction
2 participants