Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Title in Book Detail View #3216

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Fix Title in Book Detail View #3216

merged 1 commit into from
Mar 19, 2021

Conversation

jessicaawhy
Copy link
Contributor

@jessicaawhy jessicaawhy commented Mar 17, 2021

Description

This change fixes a typo in the templating. It currently shows the title of the book twice.
Screen Shot 2021-03-16 at 8 03 46 PM

I changed the template so it shows Title instead like the screenshot in the tutorial.
https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs/Displaying_data/Book_detail_page/locallibary_express_book_detail.png

Summary of Changes

Changed #{title}: #{book.title} to Title: #{book.title}

Checklist — To help your pull request get merged faster, please do the following:

    • Provide a summary of your changes — say what problem you are fixing, what files are changed, and what you've done. This doesn't need to be hugely detailed, as we can see exact changes in the "Files changed" tab.
    • Provide a link to the issue(s) you are fixing, if appropriate, in the form "Fixes url-of-issue". GitHub will render this in the form "Fixes fix: fixable flaws in Glossary A-D entries #1234", with the issue number linked to the issue. Doing this allows us to figure out what issues you are fixing, as well as helping to automate things (for example the issue will be closed once the PR that fixed it has been merged).
    • Review the results of the automated checking we run on every PR and fix any problems reported (see the list of checks near the bottom of the PR page). If you need help, please ask in a comment!
    • Link to any other resources that you think might be useful in reviewing your PR.

Example shows as `Title: #{book.title}` but the code `#{title}: #{book.title}` shows the title of the book twice.
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @jessicaawhy - you're absolutely right.

@hamishwillee hamishwillee merged commit 76fad2c into mdn:main Mar 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants