Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech review: document font-palette animation and palette-mix() #32379

Merged
merged 13 commits into from
Feb 29, 2024

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Feb 21, 2024

Description

Chrome 121 now supports animating smoothly between two font-palette values, and the palette-mix() function (which was implemented as part of supporting font-palette animation). See https://chromestatus.com/feature/5177171439517696. This PR adds the following:

  • An animation example on the font-palette reference page.
  • A dedicated palette-mix() reference page that includes an example.

Motivation

Additional details

Related issues and pull requests

Fixes #32308

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner February 21, 2024 18:58
@chrisdavidmills chrisdavidmills requested review from estelle and removed request for a team February 21, 2024 18:58
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Feb 21, 2024
Copy link
Contributor

github-actions bot commented Feb 21, 2024

Preview URLs

External URLs (3)

URL: /en-US/docs/Web/CSS/font-palette
Title: font-palette

(comment last updated: 2024-02-27 08:29:06)

@chrisdavidmills chrisdavidmills marked this pull request as draft February 22, 2024 09:30
@chrisdavidmills chrisdavidmills changed the title Add font-palette animation example Document font-palette animation and palette-mix() Feb 22, 2024
@chrisdavidmills chrisdavidmills marked this pull request as ready for review February 22, 2024 14:59
@chrisdavidmills chrisdavidmills changed the title Document font-palette animation and palette-mix() Tech review: document font-palette animation and palette-mix() Feb 22, 2024
estelle

This comment was marked as resolved.

estelle

This comment was marked as resolved.

chrisdavidmills and others added 8 commits February 26, 2024 13:47
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squee! 🎉

@estelle estelle merged commit f22871b into mdn:main Feb 29, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the font-palette-animation branch March 1, 2024 10:03
@chrisdavidmills
Copy link
Contributor Author

Awesome, thanks for the great review work @estelle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to use palette-mix() and its browser support
3 participants