Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 32386: badges are not supported on Chrome/Android #32450

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix issue 32386: badges are not supported on Chrome/Android #32450

merged 2 commits into from
Feb 29, 2024

Conversation

wbamberg
Copy link
Collaborator

Fixes #32386.

@wbamberg wbamberg requested a review from a team as a code owner February 26, 2024 23:59
@wbamberg wbamberg requested review from hamishwillee and removed request for a team February 26, 2024 23:59
@github-actions github-actions bot added Content:PWA Progressive Web Apps content size/xs [PR only] 0-5 LoC changed labels Feb 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-02-27 00:03:36)

hamishwillee
hamishwillee approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just a thought, but could this not have been effectively captured in the BCD "as well" - for example as notes on the respective lines, even for those cases when not supported?

@hamishwillee hamishwillee merged commit 4dd3bbb into mdn:main Feb 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

Assignees
No one assigned
Labels
Content:PWA Progressive Web Apps content size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why here is said that Badges supported on android?
2 participants
@wbamberg @hamishwillee