Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeunload event requires sticky activation #32479

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

pavl1
Copy link
Contributor

@pavl1 pavl1 commented Feb 29, 2024

Description

The beforeunload event should be places in Sticky activation section, not Transient activation section, at the page "Features gated by user activation".

Motivation

Documentation about the beforeunload event is inconsistent. The information on the "Features gated by user activation" page is incorrect, the information on the page "Window: beforeunload event" in the "Usage Notes" section is correct.

Additional details

Related issues and pull requests

Relates to #26772

The beforeunload event requires Sticky activation, not Transient activation. https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event#usage_notes notes the same
@pavl1 pavl1 requested a review from a team as a code owner February 29, 2024 02:02
@pavl1 pavl1 requested review from hamishwillee and removed request for a team February 29, 2024 02:02
@github-actions github-actions bot added Content:Security Security docs size/xs [PR only] 0-5 LoC changed labels Feb 29, 2024
Copy link
Contributor

Preview URLs

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you! I don't think these lists are very maintainable and would vote to remove them entirely, but this PR fixes an error, so let's merge it as-is.

@wbamberg wbamberg merged commit f568a3d into mdn:main Feb 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Security Security docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants