Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api): Remove screenshots from EmbedLiveSample calls #32505

Merged
merged 3 commits into from
Mar 2, 2024
Merged

chore(api): Remove screenshots from EmbedLiveSample calls #32505

merged 3 commits into from
Mar 2, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Mar 1, 2024

Description

This PR removes screenshots in EmbedLiveSample calls. The screenshots are used in examples that have good browser support, so they serve no purpose that I can see.

Motivation

Removing binaries from the repository. This is also an opportunity to deprecate the parameter for including screenshots in the live samples.

@bsmth bsmth requested a review from a team as a code owner March 1, 2024 11:00
@bsmth bsmth requested review from sideshowbarker and removed request for a team March 1, 2024 11:00
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Mar 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-03-01 11:02:06)

wbamberg
wbamberg approved these changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice, and +1 to deprecating this argument.

@wbamberg wbamberg merged commit 34d979b into mdn:main Mar 2, 2024
9 checks passed
@bsmth
Copy link
Member Author

bsmth commented Mar 3, 2024

Thanks!

@bsmth bsmth deleted the embedlivesample-images branch March 3, 2024 06:39
@wbamberg
Copy link
Collaborator

wbamberg commented Mar 4, 2024 •
edited
Loading

I still see screenshot arguments in the following pages:

/content/files/en-us/web/api/canvas_api/tutorial/basic_usage/index.md
/content/files/en-us/web/api/canvas_api/tutorial/drawing_shapes/index.md
/content/files/en-us/web/api/canvas_api/tutorial/using_images/index.md
/content/files/en-us/web/api/canvasrenderingcontext2d/arc/index.md
/content/files/en-us/web/api/canvasrenderingcontext2d/fillstyle/index.md
/content/files/en-us/web/api/canvasrenderingcontext2d/globalalpha/index.md
/content/files/en-us/web/api/canvasrenderingcontext2d/linecap/index.md
/content/files/en-us/web/api/canvasrenderingcontext2d/linejoin/index.md
/content/files/en-us/web/api/canvasrenderingcontext2d/strokestyle/index.md
/content/files/en-us/web/css/_doublecolon_-moz-list-number/index.md
/content/files/en-us/web/svg/element/fecolormatrix/index.md
/content/files/en-us/web/svg/element/fegaussianblur/index.md

...was it intentional to omit them?

@yin1999
Copy link
Member

yin1999 commented Mar 6, 2024 •
edited
Loading

Hey @bsmth. I'm not sure whether the image files/en-us/web/api/canvas_api/tutorial/transformations/canvas_grid_translate.png and files/en-us/web/api/canvas_api/tutorial/transformations/canvas_grid_rotate.png have been removed by mistake. There are still references to these two images in the document:

content/files/en-us/web/api/canvas_api/tutorial/transformations/index.md

Line 94 in 3d9e8e5

![The canvas is pushed down and to the right, or translated, from its origin point on the grid by 'x' units horizontally and 'y' units vertically.](canvas_grid_translate.png)

content/files/en-us/web/api/canvas_api/tutorial/transformations/index.md

Line 136 in 3d9e8e5

![The default origin point is at the top left, 0 degrees is horizontal and to the right. The rotation point starts from the origin point and goes clockwise.](canvas_grid_rotate.png)

Append (more missing images):

content/files/en-us/web/api/canvas_api/tutorial/compositing/index.md

Line 22 in 3d9e8e5

![A canvas with a star outlined in red color. The inside of the star is transparent, as portrayed by the grid squares inside the star being clearly visible whereas the grid squares lying outside the star are blurred. ](canvas_clipping_path.png)

@yin1999 yin1999 mentioned this pull request Mar 6, 2024
Merged
@bsmth
Copy link
Member Author

bsmth commented Mar 6, 2024

Thank you both for flagging these issues.

...was it intentional to omit them?

No, I wasn't sure if this pass was comprehensive.

removed by mistake

Yes I was overzealous with the image removals, my mistake! I'm following up on that with a fix now 🙏🏻

@bsmth bsmth mentioned this pull request Mar 6, 2024
Merged
@bsmth bsmth added the macros Work relating to macro refactoring or removal label Mar 6, 2024
This was referenced Mar 6, 2024
Merged
Merged
@yin1999 yin1999 mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs macros Work relating to macro refactoring or removal size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsmth @wbamberg @yin1999