Fix base64 code example #32518
Merged
Fix base64 code example #32518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `fromCodePoint(...bytes)` leads to the error `RangeError: Maximum call stack size exceeded` when `bytes` is long (it happens with 150k bytes for me with Chrome 122 on Linux). Using `Array.from` fixes this issue.
github-actions
bot
added
Content:Glossary
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Preview URLs (comment last updated: 2024-03-03 05:36:23) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
size/s
Josh-Cena
reviewed
Mar 3, 2024
Josh-Cena
approved these changes
Mar 3, 2024
|
Oh hi! Great seeing you here too! Thanks for the fix and the merge 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix error in
bytesToBase64code exampleUsing
fromCodePoint(...bytes)leads to the errorRangeError: Maximum call stack size exceededwhenbytesis long (it happens with 150k bytes for me with Chrome 122 on Linux).Using
Array.fromfixes this issue.Mention that
FileReaderandfetchoffer better performancesMotivation
Prevent developers from using a piece of code that gives the impression it's working, but might fail later if used with long data.
Additional details
Error in Chrome 122 on Linux when calling
bytesToBase64with an argument of size 150k:Related issues and pull requests
N/A