feat: Editorial review: Add docs for notRestoredReasons #32920

chrisdavidmills · 2024-04-02T07:40:59Z

Description

#27947 contains the engineering technical review for my work on notRestoredReasons docs, which has been completed and approved. Thank you to @tunetheweb for your thorough and detailed review work.

This is a new PR based on the same branch, which is intended to contain the editorial review for the same work.

Background information

The PerformanceNavigationTiming.notRestoredReasons property is finally going to be launched in Chrome 123. This PR adds a reference page for the property and associated interfaces, and a guide to using it.

See https://developer.chrome.com/docs/web-platform/bfcache-notrestoredreasons/ for further details

Motivation

Additional details

Related issues and pull requests

…e_not_restored_reasons/index.md Co-authored-by: Barry Pollard <barrypollard@google.com>

…nt into notrestoredreasons

github-actions · 2024-04-02T07:42:17Z

Preview URLs (17 pages)

External URLs (4)

URL: /en-US/docs/Web/API/Performance_API/Monitoring_bfcache_blocking_reasons
Title: Monitoring bfcache blocking reasons

https://creativecommons.org/licenses/by/4.0/ (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/web-platform/bfcache-notrestoredreasons/ (1 time) (Note! This may be a new URL 👀)
https://github.com/WICG/bfcache-not-restored-reason/blob/main/NotRestoredReason.md (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Glossary/bfcache
Title: bfcache

https://web.dev/articles/bfcache (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2024-04-12 10:06:09)

skyclouds2001

those self-links is better not to kept

files/en-us/web/api/notrestoredreasons/index.md

files/en-us/web/api/notrestoredreasondetails/index.md

files/en-us/web/api/performancenavigationtiming/index.md

files/en-us/web/api/notrestoredreasons/tojson/index.md

files/en-us/web/api/notrestoredreasondetails/tojson/index.md

Elchi3

Thanks for adding the glossary page, and addressing my other feedback! There are some links to update still but I think this could land with the fixes submitted

files/en-us/glossary/bfcache/index.md

files/en-us/web/api/notrestoredreasondetails/index.md

files/en-us/web/api/notrestoredreasondetails/reason/index.md

files/en-us/web/api/notrestoredreasondetails/tojson/index.md

files/en-us/web/api/notrestoredreasons/src/index.md

files/en-us/web/api/notrestoredreasons/tojson/index.md

files/en-us/web/api/notrestoredreasons/url/index.md

files/en-us/web/api/performancenavigationtiming/notrestoredreasons/index.md

Co-authored-by: Florian Scholz <fs@florianscholz.com>

…sons/index.md Co-authored-by: Florian Scholz <fs@florianscholz.com>

Co-authored-by: Florian Scholz <fs@florianscholz.com>

…nt into notrestoredreasons

chrisdavidmills and others added 16 commits July 14, 2023 13:26

Adds docs for notRestoredReasons

7fa1cdf

Merge branch 'main' into notrestoredreasons

79a4efb

Update files/en-us/web/api/performance_api/reporting_backforward_cach…

e039269

…e_not_restored_reasons/index.md Co-authored-by: Barry Pollard <barrypollard@google.com>

Update files/en-us/web/api/performance_api/reporting_backforward_cach…

3c288fb

…e_not_restored_reasons/index.md Co-authored-by: Barry Pollard <barrypollard@google.com>

Making fixes for review comments from tunetheweb and Josh-Cena

2779495

Merge branch 'main' into notrestoredreasons

55dcabe

Add explainer link

b3640fd

Merge branch 'notrestoredreasons' of github.com:chrisdavidmills/conte…

4210490

…nt into notrestoredreasons

Merge branch 'main' into notrestoredreasons

9bd464a

Merge branch 'main' into notrestoredreasons

827ee71

Add content to explain NotRestoredReasons empty cases

bc5cd31

Make small change to regenerate preview pages

fa9b2b1

Update content for final implementation of notRestoredReasons

7dc4028

Merge branch 'main' into notrestoredreasons

30a8cfb

Fixes for tunetheweb review comments

4e5e37e

Merge branch 'main' into notrestoredreasons

b9c2066

chrisdavidmills requested review from a team as code owners April 2, 2024 07:41

chrisdavidmills requested review from wbamberg and pepelsbey and removed request for a team April 2, 2024 07:41

github-actions bot added Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed labels Apr 2, 2024

chrisdavidmills mentioned this pull request Apr 2, 2024

Adds docs for notRestoredReasons #27947

Closed

skyclouds2001 reviewed Apr 2, 2024

View reviewed changes

files/en-us/web/api/notrestoredreasons/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/notrestoredreasons/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/notrestoredreasondetails/index.md Outdated Show resolved Hide resolved

skyclouds2001 reviewed Apr 2, 2024

View reviewed changes

files/en-us/web/api/performancenavigationtiming/index.md Outdated Show resolved Hide resolved

skyclouds2001 reviewed Apr 2, 2024

View reviewed changes

files/en-us/web/api/notrestoredreasons/tojson/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/notrestoredreasondetails/tojson/index.md Outdated Show resolved Hide resolved

wbamberg removed their request for review April 2, 2024 16:51

chrisdavidmills requested a review from Elchi3 April 10, 2024 17:42

Elchi3 approved these changes Apr 11, 2024

View reviewed changes

chrisdavidmills and others added 26 commits April 12, 2024 10:12

Update files/en-us/glossary/bfcache/index.md

16c1f37

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasondetails/index.md

afc07ae

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasondetails/reason/index.md

c770fde

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasondetails/tojson/index.md

ccb6a3c

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/performancenavigationtiming/notrestoredrea…

4615641

…sons/index.md Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/src/index.md

9d9e159

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasondetails/reason/index.md

1576c7b

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/url/index.md

f138aa9

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/tojson/index.md

1154a0b

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/url/index.md

6cced22

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/children/index.md

b680b17

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/children/index.md

1254e86

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/src/index.md

ae17c03

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/id/index.md

5687f85

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/id/index.md

a492d33

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/index.md

c1b7a89

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/reasons/index.md

31f8220

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/reasons/index.md

d1b4736

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/index.md

e3d87da

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/name/index.md

5abb2b3

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/name/index.md

07c7417

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Update files/en-us/web/api/notrestoredreasons/reasons/index.md

5398fcc

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Merge branch 'main' into notrestoredreasons

a80b30b

fix broken link

90bc4f6

Merge branch 'notrestoredreasons' of github.com:chrisdavidmills/conte…

c0de6c8

…nt into notrestoredreasons

Add CC attribution note

c62199d

chrisdavidmills merged commit 3148591 into mdn:main Apr 12, 2024
9 checks passed

chrisdavidmills deleted the notrestoredreasons branch April 12, 2024 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Editorial review: Add docs for notRestoredReasons #32920

feat: Editorial review: Add docs for notRestoredReasons #32920

chrisdavidmills commented Apr 2, 2024

github-actions bot commented Apr 2, 2024 •

edited

Loading

skyclouds2001 left a comment

Elchi3 left a comment •

edited

Loading

feat: Editorial review: Add docs for notRestoredReasons #32920

feat: Editorial review: Add docs for notRestoredReasons #32920

Conversation

chrisdavidmills commented Apr 2, 2024

Description

Background information

Motivation

Additional details

Related issues and pull requests

github-actions bot commented Apr 2, 2024 • edited Loading

skyclouds2001 left a comment

Choose a reason for hiding this comment

Elchi3 left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Apr 2, 2024 •

edited

Loading

Elchi3 left a comment •

edited

Loading