Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for shadow root serializable property (everywhere) #33600

Merged
merged 8 commits into from
May 17, 2024

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 14, 2024

This adds docs for

Note, minimal examples - might add as a post process since there are multiple PRs in play covering similar material.

Parallel work going on in #33325

Related to work for #32731

@hamishwillee hamishwillee requested review from a team as code owners May 14, 2024 03:48
@hamishwillee hamishwillee requested review from sideshowbarker and estelle and removed request for a team May 14, 2024 03:48
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels May 14, 2024
Copy link
Contributor

github-actions bot commented May 14, 2024

Preview URLs (9 pages)
Flaws (11)

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/ShadowRoot
Title: ShadowRoot
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/ShadowRoot/getSelection does not exist
    • /en-US/docs/Web/API/ShadowRoot/elementFromPoint does not exist
    • /en-US/docs/Web/API/ShadowRoot/elementsFromPoint does not exist

URL: /en-US/docs/Web/API/ShadowRoot/getHTML
Title: ShadowRoot: getHTML() method
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/ShadowRoot/setHTMLUnsafe does not exist
    • /en-US/docs/Web/API/Element/setHTMLUnsafe does not exist

URL: /en-US/docs/Web/API/Element/getHTML
Title: Element: getHTML() method
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Element/setHTMLUnsafe does not exist
    • /en-US/docs/Web/API/ShadowRoot/setHTMLUnsafe does not exist

URL: /en-US/docs/Web/API/Element/innerHTML
Title: Element: innerHTML property
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/Element/setHTMLUnsafe does not exist
    • /en-US/docs/Web/API/ShadowRoot/setHTMLUnsafe does not exist
    • /en-US/docs/Web/API/Element/setHTMLUnsafe does not exist
    • /en-US/docs/Web/API/ShadowRoot/setHTMLUnsafe does not exist
External URLs (2)

URL: /en-US/docs/Web/API/Element/innerHTML
Title: Element: innerHTML property

(comment last updated: 2024-05-17 09:11:02)

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label May 17, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label May 17, 2024
@hamishwillee hamishwillee force-pushed the shadowroot_serializable branch from 377c852 to 1691f94 Compare May 17, 2024 03:19
files/en-us/web/api/element/innerhtml/index.md Outdated Show resolved Hide resolved
- {{domxref("Element.getHTML()")}}
- {{domxref("Element.innerHTML")}}
- {{domxref("ShadowRoot.setHTMLUnsafe()")}}
- {{domxref("Element.setHTMLUnsafe()")}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- {{domxref("Element.setHTMLUnsafe()")}}
- {{domxref("Element.setHTMLUnsafe()")}}

hamishwillee and others added 2 commits May 17, 2024 14:37
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hamishwillee
Copy link
Collaborator Author

@sideshowbarker Could I please get a review on this. It should be accurate and useful.

I may do follow on examples, but those mostly below in getHTML() and setHTMLUnsafe() - one of which is still being written.

@sideshowbarker sideshowbarker merged commit 096fcee into mdn:main May 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants