-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section on Iterator error handling #34069
Conversation
Preview URLs
(comment last updated: 2024-06-12 06:36:32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks decent at a glance! You might also be interested in this doc I wrote on this topic (which I haven't gotten around to cleaning up and linking anywhere).
files/en-us/web/javascript/reference/iteration_protocols/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/iteration_protocols/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
Thanks for the link—that's really helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving a +1 here based on reviewer feedback so you may merge when you're happy! Thanks, both!
I'll also assume the current content is fine :D |
Fix #27636.
@bakkot Maybe you'll be interested in taking a look—please let me know if the content is technically accurate and is what the spec considers as good convention. Thanks!