Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on Iterator error handling #34069

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

Josh-Cena
Copy link
Member

Fix #27636.

@bakkot Maybe you'll be interested in taking a look—please let me know if the content is technically accurate and is what the spec considers as good convention. Thanks!

@Josh-Cena Josh-Cena requested a review from a team as a code owner June 12, 2024 05:29
@Josh-Cena Josh-Cena requested review from teoli2003 and removed request for a team June 12, 2024 05:29
@github-actions github-actions bot added Content:JS JavaScript docs size/m [PR only] 51-500 LoC changed labels Jun 12, 2024
Copy link
Contributor

github-actions bot commented Jun 12, 2024

Preview URLs

(comment last updated: 2024-06-12 06:36:32)

Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks decent at a glance! You might also be interested in this doc I wrote on this topic (which I haven't gotten around to cleaning up and linking anywhere).

Josh-Cena and others added 2 commits June 12, 2024 02:26
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
@Josh-Cena
Copy link
Member Author

Thanks for the link—that's really helpful.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving a +1 here based on reviewer feedback so you may merge when you're happy! Thanks, both!

@Josh-Cena
Copy link
Member Author

I'll also assume the current content is fine :D

@Josh-Cena Josh-Cena merged commit ec69cf4 into mdn:main Jun 19, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the iterator-errors branch July 8, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Info about rejected promises in the async iterator protocol
3 participants