Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New properties: SVG x and y #34931

Merged
merged 6 commits into from
Aug 7, 2024
Merged

New properties: SVG x and y #34931

merged 6 commits into from
Aug 7, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jul 19, 2024

related to #34763

@estelle estelle requested a review from a team as a code owner July 19, 2024 20:41
@estelle estelle requested review from bsmth and removed request for a team July 19, 2024 20:41
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jul 19, 2024
Copy link
Contributor

github-actions bot commented Jul 19, 2024

Preview URLs

Flaws (5)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/y
Title: y
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/fill
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/fill
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/stroke

URL: /en-US/docs/Web/CSS/x
Title: x
Flaw count: 2

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/fill
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/stroke

(comment last updated: 2024-08-06 23:54:26)

@bsmth
Copy link
Member

bsmth commented Aug 1, 2024

Thanks, Estelle! I've a few questions and some comments if you want to have a look 👀

estelle and others added 4 commits August 6, 2024 00:12
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@estelle estelle requested a review from a team as a code owner August 6, 2024 23:53
@estelle estelle requested review from hamishwillee and removed request for a team August 6, 2024 23:53
@github-actions github-actions bot added the Content:SVG SVG docs label Aug 6, 2024
@estelle
Copy link
Member Author

estelle commented Aug 7, 2024

Thanks, Estelle! I've a few questions and some comments if you want to have a look 👀

Thanks @bsmth. SVGs are images, so they are left to right, as far as i know and my tests show. If you know something i don't, please LMK (link?).
X and Y aren't supported on <text> as CSS properties; this might be why.

@estelle estelle requested a review from bsmth August 7, 2024 00:10
@estelle estelle mentioned this pull request Aug 7, 2024
@bsmth
Copy link
Member

bsmth commented Aug 7, 2024

If you know something i don't, please LMK (link?)

No I was just curious if this had an effect on coords / origin, so if you've tested, then that's great!

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@estelle estelle merged commit c276224 into main Aug 7, 2024
9 checks passed
@estelle estelle deleted the xy branch August 7, 2024 17:11
@@ -867,7 +867,7 @@ For {{SVGElement('foreignObject')}}, `y` defines the y coordinate of the upper l
</tbody>
</table>

> [!Note]
> ![NOTE]
Copy link
Member

@Josh-Cena Josh-Cena Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the ! in the wrong place here; this will be caught by #35344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants