-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New properties: SVG x and y #34931
New properties: SVG x and y #34931
Conversation
Preview URLs
Flaws (5)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
(comment last updated: 2024-08-06 23:54:26) |
Thanks, Estelle! I've a few questions and some comments if you want to have a look 👀 |
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Thanks @bsmth. SVGs are images, so they are left to right, as far as i know and my tests show. If you know something i don't, please LMK (link?). |
No I was just curious if this had an effect on coords / origin, so if you've tested, then that's great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
@@ -867,7 +867,7 @@ For {{SVGElement('foreignObject')}}, `y` defines the y coordinate of the upper l | |||
</tbody> | |||
</table> | |||
|
|||
> [!Note] | |||
> ![NOTE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have the !
in the wrong place here; this will be caught by #35344
related to #34763