Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG attributes: geometry property notes #34936

Merged
merged 3 commits into from
Jul 23, 2024
Merged

SVG attributes: geometry property notes #34936

merged 3 commits into from
Jul 23, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jul 20, 2024 •
edited
Loading

the geometry propery pages were created. this adds links to those pages.
removing the "svg 2" info as it's well supported, and the browser doesn't care which version you're targeting.

related to #34763

@estelle estelle requested a review from a team as a code owner July 20, 2024 07:02
@estelle estelle requested review from hamishwillee and removed request for a team July 20, 2024 07:02
@github-actions github-actions bot added Content:SVG SVG docs size/s [PR only] 6-50 LoC changed labels Jul 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 20, 2024 •
edited
Loading

Preview URLs (7 pages)
Flaws (14)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/SVG/Attribute/cy
Title: cy
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/cy does not exist
    • /en-US/docs/Web/CSS/cy does not exist

URL: /en-US/docs/Web/SVG/Attribute/x
Title: x
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/x does not exist
    • /en-US/docs/Web/CSS/x does not exist
    • /en-US/docs/Web/CSS/x does not exist
    • /en-US/docs/Web/CSS/x does not exist
    • /en-US/docs/Web/CSS/x does not exist

URL: /en-US/docs/Web/SVG/Attribute/y
Title: y
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/y does not exist
    • /en-US/docs/Web/CSS/y does not exist
    • /en-US/docs/Web/CSS/y does not exist
    • /en-US/docs/Web/CSS/y does not exist
    • /en-US/docs/Web/CSS/y does not exist

URL: /en-US/docs/Web/SVG/Attribute/cx
Title: cx
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/cx does not exist
    • /en-US/docs/Web/CSS/cx does not exist

(comment last updated: 2024-07-22 23:05:14)

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jul 20, 2024
@estelle estelle changed the title SVG attributes: geometry properties SVG attributes: geometry property notes Jul 20, 2024
@estelle @hamishwillee
Update files/en-us/web/svg/attribute/x/index.md
a62867d 
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
hamishwillee
hamishwillee approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you.

@hamishwillee hamishwillee merged commit 7665858 into main Jul 23, 2024
9 checks passed
@hamishwillee hamishwillee deleted the svggeolinks branch July 23, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

Assignees
No one assigned
Labels
Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @hamishwillee