Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CSS vector-effect property #34974

Merged
merged 11 commits into from
Aug 12, 2024
Merged

Added CSS vector-effect property #34974

merged 11 commits into from
Aug 12, 2024

Conversation

meyerweb
Copy link
Contributor

Description

Adds documentation of the CSS property vector-effect, which is an SVG attribute, including a couple of examples showing the one value that is widely supported (in both SVG and CSS).

Motivation

The page doesn’t exist, and it needs to be created (see #34763).

@meyerweb meyerweb requested a review from a team as a code owner July 22, 2024 20:03
@meyerweb meyerweb requested review from chrisdavidmills and removed request for a team July 22, 2024 20:03
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/vector-effect
Title: vector-effect
Flaw count: 1

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/stroke

(comment last updated: 2024-08-12 21:26:48)

@meyerweb meyerweb requested a review from a team as a code owner July 24, 2024 16:42
@github-actions github-actions bot added the Content:SVG SVG docs label Jul 24, 2024
@bsmth
Copy link
Member

bsmth commented Aug 1, 2024

Thanks, Eric. Taking a look shortly 👀

@bsmth
Copy link
Member

bsmth commented Aug 1, 2024

Looking good, thanks! A couple of small questions for you to look at!

meyerweb and others added 5 commits August 1, 2024 22:54
@meyerweb
Added transforrms link
4f7f112
@meyerweb
Expanded on use cases
5e1675d
@meyerweb @bsmth
Update files/en-us/web/css/vector-effect/index.md
c5ef2ad 
Accepting bsmth’s recommendation

Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@meyerweb @bsmth
Update files/en-us/web/css/vector-effect/index.md
e4435bd 
Accepting bsmth’s recommendation

Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@bsmth
Merge branch 'main' into css/vector-effect
4cb5874
bsmth
bsmth approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Eric! One suggestion for you, but ready to go, then.

@meyerweb @bsmth
Update files/en-us/web/css/vector-effect/index.md
4146774 
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@meyerweb
Copy link
Contributor Author

meyerweb commented Aug 12, 2024 •
edited
Loading

Okay, I’m back from holidays and committed the suggestion. Thank you!

@Josh-Cena Josh-Cena merged commit 448c98d into mdn:main Aug 12, 2024
8 checks passed
@meyerweb meyerweb deleted the css/vector-effect branch August 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@bsmth bsmth bsmth approved these changes

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meyerweb @bsmth @Josh-Cena