Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSS dominant-baseline property #35227

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

meyerweb
Copy link
Contributor

Description

Adds documentation of the CSS property dominant-baseline, which replicates an SVG attribute.

Motivation

The page currently doesn’t exist, and needs to be created (see #34763).

@meyerweb meyerweb requested review from a team as code owners July 29, 2024 19:10
@meyerweb meyerweb requested review from estelle and Elchi3 and removed request for a team July 29, 2024 19:10
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed labels Jul 29, 2024
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/dominant-baseline
Title: dominant-baseline
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/alignment-baseline does not exist

(comment last updated: 2024-08-13 21:04:23)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand one of the sentences, which is repeated a few times.

files/en-us/web/css/dominant-baseline/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/dominant-baseline/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/dominant-baseline/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/dominant-baseline/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/dominant-baseline/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/dominant-baseline/index.md Outdated Show resolved Hide resolved
Committing Estelle’s excellent suggestions.

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
github-actions changes

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Josh-Cena Josh-Cena requested a review from estelle August 12, 2024 23:54
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

will check once live if still redirecting.

@estelle estelle merged commit e295790 into mdn:main Aug 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants