Correct Speculation Rules HTTP Status code support #35624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2024-08-28 16:46:19) |
wbamberg
reviewed
Aug 28, 2024
| Servers can respond based on this header, for example, to log speculative load requests, return different content, or even prevent speculative loading from happening. If a non-success response code is returned (any HTTP status other than 200 or 304), then the page will not be prefetched/prerendered. This is the easiest way to prevent speculative loading, although it is usually a better approach to allow the prefetch/prerender, and use JavaScript to delay any actions that should only happen when the page is actually viewed. | ||
| Servers can respond based on this header, for example, to log speculative load requests, return different content, or even prevent speculative loading from happening. If a non-success response code is returned (any HTTP status other than in the 200-299 range after redirects), then the page will not be prefetched/prerendered. In addition the 204 and 205 status codes also prevent prerendering (but do not prevent prefetch). | ||
|
|
||
| Using a non-success code (for example a 504) is the easiest way to prevent speculative loading server-side, although it is usually a better approach to allow the prefetch/prerender, and use JavaScript to delay any actions that should only happen when the page is actually viewed. |
There was a problem hiding this comment.
Is 504 intentional here? This comment: WICG/nav-speculation#330 (comment) suggests 503, which seems closer in intent.
There was a problem hiding this comment.
Oh good spot! Fixed.
wbamberg
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
This looks good to me. Approving but leaving open in case you want feedback from the people in WICG/nav-speculation#330.
|
Think we're good cause @jeremyroman (the spec author) LGTMed my similar change on the Chrome Docs. But he can give an LGTM comment if you prefer to wait for that? |
I'm happy if you are! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MDN previously incorrectly stated that status codes 200 and 304 were supported for Speculation Rules based on incorrect data in the Chrome documentation (that has since been corrected).
Motivation
We've had a developer report of confusion due to incorrect information:
WICG/nav-speculation#330
Additional details
See above links.
Details in spec
Related issues and pull requests