Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new declarativeNetRequest RuleConditions #35649

Merged

Conversation

@danielhjacobs danielhjacobs requested a review from a team as a code owner August 30, 2024 14:01
@danielhjacobs danielhjacobs requested review from willdurand and removed request for a team August 30, 2024 14:01
@github-actions github-actions bot added Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed labels Aug 30, 2024
Copy link
Contributor

github-actions bot commented Aug 30, 2024

Preview URLs

Flaws (2)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/HeaderInfo
Title: declarativeNetRequest.HeaderInfo
Flaw count: 2

  • bad_bcd_queries:
    • No BCD data for query: webextensions.api.declarativeNetRequest.RuleCondition.responseHeaders
    • No BCD data for query: webextensions.api.declarativeNetRequest.RuleCondition.excludedResponseHeaders
External URLs (1)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/HeaderInfo
Title: declarativeNetRequest.HeaderInfo

(comment last updated: 2024-09-25 15:29:45)

@danielhjacobs danielhjacobs force-pushed the add-response-header-rule-condition branch 2 times, most recently from 63364ea to e0f5823 Compare August 30, 2024 14:04
@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Aug 30, 2024

The flaws are because the BCD PR hasn't been merged yet.

@danielhjacobs danielhjacobs force-pushed the add-response-header-rule-condition branch from db74706 to 67bc969 Compare August 30, 2024 14:20
@willdurand willdurand requested review from Rob--W and removed request for willdurand September 5, 2024 10:28
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please apply the suggested changes and merge it after that.

@danielhjacobs
Copy link
Contributor Author

I have applied the requested changes.

@queengooborg queengooborg merged commit a0835f7 into mdn:main Oct 2, 2024
8 checks passed
@danielhjacobs danielhjacobs deleted the add-response-header-rule-condition branch October 2, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add responseHeaders and excludedResponseHeaders RuleCondition
3 participants