Match pattern fragment clarification #36069
Conversation
|
Preview URLs External URLs (1)URL:
(comment last updated: 2024-11-17 22:47:01) |
| @@ -342,6 +342,10 @@ The special value `<all_urls>` matches all URLs under any of the supported schem | |||
| <td><code>https://mozilla.org</code></td> | |||
| <td>No path.</td> | |||
| </tr> | |||
| <tr> | |||
| <td><code>https://mozilla.org/#section1</code></td> | |||
| <td>Contains an unsupported match character.</td> | |||
There was a problem hiding this comment.
This is not a syntactically invalid match pattern, just one that never matches.
The other examples here are examples of match patterns that are rejected as a value for "match pattern" types, but this one is accepted.
On the other hand, the example below with a host name is also syntactically valid but listed as invalid. In Chrome it is valid but in Firefox it is ignored.
| @@ -342,6 +342,10 @@ The special value `<all_urls>` matches all URLs under any of the supported schem | |||
| <td><code>https://mozilla.org</code></td> | |||
| <td>No path.</td> | |||
| </tr> | |||
| <tr> | |||
| <td><code>https://mozilla.org/#section1</code></td> | |||
| <td>Contains an unsupported match character.</td> | |||
There was a problem hiding this comment.
| <td>Contains an unsupported match character.</td> | |
| <td>Contains a reference fragment, which are never included in the URLs to match against.</td> |
Can probably be phrased better than this. It is not that the character is unsupported technically, but that the URL that the pattern is matched against never includes the reference fragment.
There was a problem hiding this comment.
@Rob--W made some changes to address, let me know what you think
Description
Clarifies how fragments are handled in response to #14018
Related issues and pull requests
Fixes #14018