Fix buffer length typo #36946
Merged
Fix buffer length typo #36946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of workgroups and global id check should be based on the number of elements, not the size of the buffer in bytes
github-actions
bot
added
Content:WebAPI
sideshowbarker
approved these changes
Nov 26, 2024
|
Preview URLs |
|
@robz Nice work; congrats on landing your first docs change here — welcome aboard 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The number of workgroups and global id check should be based on the number of elements, not the size of the buffer in bytes
Motivation
I ran into this issue while replicating the tutorial (https://developer.mozilla.org/en-US/docs/Web/API/WebGPU_API), and got confused by the different lengths. Hopefully fixing it here will save time for others