Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextUpdateEvent.selectionStart #36966

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

mikecat
Copy link
Contributor

@mikecat mikecat commented Nov 25, 2024

Description

selectionStart is the start, not the end.

Motivation

Additional details

Related issues and pull requests

@mikecat mikecat requested a review from a team as a code owner November 25, 2024 14:28
@mikecat mikecat requested review from wbamberg and removed request for a team November 25, 2024 14:28
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Nov 25, 2024
Copy link
Contributor

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@wbamberg wbamberg merged commit 76f2007 into mdn:main Nov 25, 2024
7 checks passed
@mikecat mikecat deleted the fix-textupdateevent-selectionstart branch November 25, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants