Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDN Feature Pages for SVGAnimatedAngle: animVal and baseVal #37068

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

yashrajbharti
Copy link
Contributor

Description

This PR adds the MDN feature pages for the SVGAnimatedAngle interface as part of a recent project to document missing Widely available pages for interface features.

Motivation

I believe that my support in documenting the SVGAnimatedAngle interface can significantly help developers by providing essential resources.

Additional details

For more context, see the discussion on missing documentation tracked at https://openwebdocs.github.io/web-docs-backlog/baseline/. Additionally, related projects for adding widely available web features can be found at openwebdocs/project#214.

Related issues and pull requests

Relates to #214

@yashrajbharti yashrajbharti requested a review from a team as a code owner December 3, 2024 14:22
@yashrajbharti yashrajbharti requested review from wbamberg and removed request for a team December 3, 2024 14:22
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 3, 2024
@yashrajbharti yashrajbharti changed the title add: MDN Feature Pages for SVGAnimatedAngle: animaval and baseval MDN Feature Pages for SVGAnimatedAngle: animaval and baseval Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Preview URLs

Flaws (1)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/SVGAnimatedAngle/baseVal
Title: SVGAnimatedAngle: baseVal property
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/SVGAngle/unitType does not exist

(comment last updated: 2024-12-06 05:49:53)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It looks good.

I gave some feedback that's relevant to this PR and also some for all API pages.

files/en-us/web/api/svganimatedangle/animval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatedangle/animval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatedangle/baseval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatedangle/baseval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatedangle/baseval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatedangle/index.md Outdated Show resolved Hide resolved
@yashrajbharti yashrajbharti changed the title MDN Feature Pages for SVGAnimatedAngle: animaval and baseval MDN Feature Pages for SVGAnimatedAngle: animVal and baseVal Dec 5, 2024
@yashrajbharti
Copy link
Contributor Author

Thanks for all the wonderful suggestions! I have started fixing these in other pages and learning on the way.

@yashrajbharti yashrajbharti requested a review from estelle December 5, 2024 00:48
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor tweaks and good to go.

files/en-us/web/api/svganimatedangle/animval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatedangle/baseval/index.md Outdated Show resolved Hide resolved
yashrajbharti and others added 4 commits December 6, 2024 11:15
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@yashrajbharti yashrajbharti requested a review from estelle December 6, 2024 05:48
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@estelle estelle merged commit 6db682e into mdn:main Dec 6, 2024
8 checks passed
@yashrajbharti yashrajbharti deleted the feat/svganimatedangle branch December 6, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants