Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDN Feature pages for SVGAnimatedNumber #37072

Merged
merged 18 commits into from
Dec 15, 2024

Conversation

yashrajbharti
Copy link
Contributor

Description

This PR adds the MDN feature pages for the SVGAnimatedNumber interface as part of a recent project to document missing Widely available pages for interface features.

Motivation

I believe that my support in documenting the SVGAnimatedNumber interface can significantly help developers by providing essential resources.

Additional details

For more context, see the discussion on missing documentation tracked at https://openwebdocs.github.io/web-docs-backlog/baseline/. Additionally, related projects for adding widely available web features can be found at openwebdocs/project#214.

Related issues and pull requests

Relates to #214

@yashrajbharti yashrajbharti requested a review from a team as a code owner December 3, 2024 15:46
@yashrajbharti yashrajbharti requested review from sideshowbarker and removed request for a team December 3, 2024 15:46
@yashrajbharti yashrajbharti changed the title add: MDN Feature pages for SVGAnimatedNumber MDN Feature pages for SVGAnimatedNumber Dec 3, 2024
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Preview URLs

Flaws (2)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/SVGAnimatedNumber/baseVal
Title: SVGAnimatedNumber: baseVal property
Flaw count: 1

  • macros:
    • /en-US/docs/Web/SVG/Element/pathLength does not exist

URL: /en-US/docs/Web/API/SVGAnimatedNumber/animVal
Title: SVGAnimatedNumber: animVal property
Flaw count: 1

  • macros:
    • /en-US/docs/Web/SVG/Element/pathLength does not exist

(comment last updated: 2024-12-14 19:08:16)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added (and committed) an example and suggested and edits to reflect that edit

@estelle
Copy link
Member

estelle commented Dec 14, 2024

added (and committed) an example and suggested and edits to reflect that edit

OOps, my suggestions we made based on the content before your commits from 4 hours ago.

@estelle estelle self-assigned this Dec 14, 2024
@yashrajbharti
Copy link
Contributor Author

No worries! Everything is fixed 😊, thanks for the suggestions!

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really close. just a few more tidbits.

files/en-us/web/api/svganimatednumber/animval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatednumber/baseval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatednumber/baseval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatednumber/baseval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatednumber/baseval/index.md Outdated Show resolved Hide resolved
yashrajbharti and others added 5 commits December 15, 2024 00:34
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
yashrajbharti and others added 2 commits December 15, 2024 00:36
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@estelle estelle merged commit 5f0dba0 into mdn:main Dec 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants