fix(css): descriptions on logical padding pages #37085
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnkarRuikar
requested review from
chrisdavidmills
and removed request for
a team
github-actions
bot
added
Content:CSS
Preview URLs (6 pages)(comment last updated: 2024-12-05 02:47:09) |
chrisdavidmills
requested changes
Dec 4, 2024
There was a problem hiding this comment.
@OnkarRuikar Some nice changes here Onkar, good work. I've suggested quite a few changes here, but nothing major, and they are basically just the same comment multiple times on different pages.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
chrisdavidmills
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Perfect, let's get this merged! Thanks again @OnkarRuikar! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be better to have the same statements on all the pages. We need to be explicit about the value and visual appearance parts.