Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group WebAssembly docs into Guides and Reference #37899

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

pepelsbey
Copy link
Member

@pepelsbey pepelsbey commented Jan 31, 2025

Moves pages into guides and reference folders

- webassembly/c_to_wasm
+ webassembly/guides/c_to_wasm
- webassembly/javascript_interface
+ webassembly/reference/javascript_interface
etc.

Creates landing pages for guides and references

+ webassembly/reference/index.md
+ webassembly/guides/index.md

Uses front-matter sidebar

+ sidebar: webassemblysidebar
- {{WebAssemblySidebar}}

Uses new page type

+ page-type: listing-page

Motivation

Docs IA & maintenance

TODO

  • Check links in BCD
  • Fix links in web-features

@github-actions github-actions bot added the Content:wasm WebAssembly docs label Jan 31, 2025
@pepelsbey pepelsbey requested a review from bsmth January 31, 2025 13:11
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Preview URLs (135 pages)
Flaws (4)

Note! 132 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/62
Title: Firefox 62 for developers
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
  • macros:
    • Macro produces link /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/referrer which is a redirect

URL: /en-US/docs/Mozilla/Firefox/Releases/100
Title: Firefox 100 for developers
Flaw count: 1

  • macros:
    • Can't resolve /en-US/docs/Web/HTTP/Headers/Large-Allocation

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy
Title: Content-Security-Policy (CSP)
Flaw count: 1

  • unknown:
    • No generic content config found
External URLs (25)

URL: /en-US/docs/WebAssembly/Guides/Using_the_JavaScript_API
Title: Using the WebAssembly JavaScript API


URL: /en-US/docs/WebAssembly/Guides/Concepts
Title: WebAssembly concepts


URL: /en-US/docs/WebAssembly/Guides/Understanding_the_text_format
Title: Understanding WebAssembly text format


URL: /en-US/docs/WebAssembly/Reference/JavaScript_interface/compile_static
Title: WebAssembly.compile()


URL: /en-US/docs/WebAssembly/Reference/JavaScript_interface/Table
Title: WebAssembly.Table


URL: /en-US/docs/WebAssembly/Reference/JavaScript_interface/Table/get
Title: WebAssembly.Table.prototype.get()


URL: /en-US/docs/WebAssembly/Reference/JavaScript_interface/Table/set
Title: WebAssembly.Table.prototype.set()


URL: /en-US/docs/WebAssembly/Reference/JavaScript_interface/Memory
Title: WebAssembly.Memory


URL: /en-US/docs/WebAssembly/Reference/JavaScript_interface/Memory/Memory
Title: WebAssembly.Memory() constructor


URL: /en-US/docs/WebAssembly/Reference/JavaScript_interface/Memory/buffer
Title: WebAssembly.Memory.prototype.buffer


URL: /en-US/docs/WebAssembly/Reference/JavaScript_interface/Module/Module
Title: WebAssembly.Module() constructor


URL: /en-US/docs/WebAssembly/Reference/JavaScript_interface/compileStreaming_static
Title: WebAssembly.compileStreaming()


URL: /en-US/docs/Mozilla/Firefox/Releases/58
Title: Firefox 58 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/62
Title: Firefox 62 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/79
Title: Firefox 79 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/100
Title: Firefox 100 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/64
Title: Firefox 64 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/131
Title: Firefox 131 for developers

(comment last updated: 2025-01-31 14:20:48)

@github-actions github-actions bot added Content:WebAPI Web API docs Content:JS JavaScript docs Content:HTTP HTTP docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Meta Content in the meta docs labels Jan 31, 2025
@pepelsbey pepelsbey marked this pull request as ready for review January 31, 2025 13:14
@pepelsbey pepelsbey requested review from a team as code owners January 31, 2025 13:14
@pepelsbey pepelsbey requested review from Josh-Cena and removed request for a team January 31, 2025 13:14
@github-actions github-actions bot added size/xl [PR only] >1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Jan 31, 2025
@sideshowbarker sideshowbarker removed request for a team January 31, 2025 13:23
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look through everything, so leaving a +1 with the same comment for front-matter v macro usage, and a comment about the sidebar yml.

@pepelsbey pepelsbey removed request for a team and Josh-Cena January 31, 2025 14:16
@pepelsbey pepelsbey merged commit df9d064 into mdn:main Jan 31, 2025
9 checks passed
@pepelsbey pepelsbey deleted the move/webassembly branch January 31, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:HTTP HTTP docs Content:JS JavaScript docs Content:Meta Content in the meta docs Content:wasm WebAssembly docs Content:WebAPI Web API docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants