-
Notifications
You must be signed in to change notification settings - Fork 23k
Update forbidden request headers in glossary #41830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,16 +28,17 @@ Forbidden headers are one of the following: | |
| - {{HTTPHeader("Connection")}} | ||
| - {{HTTPHeader("Content-Length")}} | ||
| - {{HTTPHeader("Cookie")}} | ||
| - `Cookie2` | ||
| - {{HTTPHeader("Date")}} | ||
| - {{HTTPHeader("DNT")}} | ||
| - {{HTTPHeader("Expect")}} | ||
| - {{HTTPHeader("Host")}} | ||
| - {{HTTPHeader("Keep-Alive")}} | ||
| - {{HTTPHeader("Origin")}} | ||
| - {{HTTPHeader("Permissions-Policy")}} | ||
| - `Proxy-` headers | ||
| - `Sec-` headers | ||
| - {{HTTPHeader("Referer")}} | ||
| - {{HTTPHeader("Set-Cookie")}} | ||
hamishwillee marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - {{HTTPHeader("TE")}} | ||
| - {{HTTPHeader("Trailer")}} | ||
| - {{HTTPHeader("Transfer-Encoding")}} | ||
|
|
@@ -53,6 +54,9 @@ Forbidden headers are one of the following: | |
| > [!NOTE] | ||
| > While the {{HTTPHeader("Referer")}} header is listed as a forbidden header [in the spec](https://fetch.spec.whatwg.org/#forbidden-request-header), the user agent does not retain full control over it and the header can be programmatically modified. For example, when using [`fetch()`](/en-US/docs/Web/API/Window/fetch), the {{HTTPHeader("Referer")}} header can be programmatically modified via the [`referrer` option](/en-US/docs/Web/API/RequestInit#referrer). | ||
|
|
||
| > [!NOTE] | ||
| > Chrome also forbids `Access-Control-Request-Private-Network` | ||
|
Comment on lines
+57
to
+58
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FWIW We should document this header and add it to BCD mdn/browser-compat-data#25467. Because we have not done so I think this is good (because there is no way for anyone to work out the support story on this) but when BCD/docs exist this would just be in the main list. |
||
|
|
||
| ## See also | ||
|
|
||
| - Related glossary terms: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What browser is this implemented in? MDN doesn't document things that have no implementation.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All 3 of them. I linked the Chrome source code and I also ran the snippet I posted above that sends the 4 mentioned headers on macOS:
Chrome

Safari

Firefox

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, some context on removal:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that clarification @bsmth - I should have searched the history.
I have reverted this in #41964 because Cookie2 is not part of the web platform. I suspect this will come up again until the spec gets updated to remove the mention of this header.