Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(attributes): link to datetime #4261

Closed
wants to merge 1 commit into from
Closed

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Apr 19, 2021

Fixes #4256

@simon04 simon04 requested a review from a team as a code owner April 19, 2021 17:12
@simon04 simon04 requested review from rachelandrew and removed request for a team April 19, 2021 17:12
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/HTML/Attributes
Title: HTML attribute reference
on GitHub
Flaw count: 46

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Attributes/action
    • Can't resolve /en-US/docs/Web/HTML/Attributes/align
    • Can't resolve /en-US/docs/Web/HTML/Attributes/alt
    • Can't resolve /en-US/docs/Web/HTML/Attributes/autofocus
    • Can't resolve /en-US/docs/Web/HTML/Attributes/autoplay
    • and 41 more flaws omitted

External URLs

URL: /en-US/docs/Web/HTML/Attributes
Title: HTML attribute reference
on GitHub

Copy link
Member

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right fix. The problem is that there are multiple elements which have a datetime attribute — not just the input element, but also the del and ins. So it’s not correct to link to just the input element’s datetime attribute.

What might be correct instead is to remove the link there completely.

But there seem to be about 47 other attributes in that index page which have the same problem. So whatever we do for datetime we should do consistently for all those other ones too.

@rachelandrew
Copy link
Collaborator

There is a tracking issue here #1712 we need to write the docs for these missing pages.

@sideshowbarker
Copy link
Member

There is a tracking issue here #1712 we need to write the docs for these missing pages.

OK, thanks — given that we have #1712 for the core issue, I’ve gone ahead and closed #4256 as a duplicate of that, and so will now close this PR too.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "HTML attribute reference": datetime attribute link is broken
3 participants