Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop outdated support info from Window.open doc #4580

Merged

Conversation

sideshowbarker
Copy link
Collaborator

Fixes #4363

@sideshowbarker sideshowbarker requested a review from a team as a code owner April 29, 2021 02:22
@sideshowbarker sideshowbarker requested review from wbamberg and removed request for a team April 29, 2021 02:22
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Window/open
Title: Window.open()
on GitHub
Flaw count: 5

  • macros:
    • /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
    • /en-us/docs/web/api/speechsynthesisgetter (url: /en-US/docs/Web/API/SpeechSynthesisGetter) does not exist
    • /en-us/docs/web/api/windowmodal (url: /en-US/docs/Web/API/WindowModal) does not exist
    • /en-us/docs/web/api/onerroreventhandlerforwindow (url: /en-US/docs/Web/API/OnErrorEventHandlerForWindow) does not exist
    • /en-us/docs/web/api/chromewindow (url: /en-US/docs/Web/API/ChromeWindow) does not exist

External URLs

URL: /en-US/docs/Web/API/Window/open
Title: Window.open()
on GitHub

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sideshowbarker ! This is a scary page.

@wbamberg wbamberg merged commit e126945 into main Apr 29, 2021
@wbamberg wbamberg deleted the sideshowbarker/Window.open-drop-inaccurate-support-statement branch April 29, 2021 03:56
@sideshowbarker
Copy link
Collaborator Author

Thanks @sideshowbarker ! This is a scary page.

🤣 Yeah it gives a rich variety of opportunities for eyebrow raising, including with the parts that have ended up unintentionally becoming a bit of a journey down memory lane — especially in the FAQ bits. There are probably some lessons we could learn from this about, e.g., future-proofing content a bit better. But anyway, maybe somebody will someday take an interest in refactoring the whole article — including dragging it a bit further into the 21st century.

@wbamberg
Copy link
Collaborator

I couldn't not file a bug for this -> #4583 .

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "Window.open()": Incorrect statement that empty URL only works from the parent
2 participants