-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the Window Proxy page #4630
Conversation
Preview URLsFlawsNone! 🎉 External URLsURL:
(this comment was updated 2021-04-30 21:00:37.029251) (this comment was updated 2021-05-04 08:49:00.380367) (this comment was updated 2021-05-05 07:06:22.593479) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've given this a copy edit, and the language now sounds good. Thanks for the contribution @jamesaucode ! I also think that this belongs in the glossary, so the position is OK.
I'd also like someone else who know a bit more about such internals to have a look at this, and give a second opinion on the content. @sideshowbarker can you have a look when you get the chance?
Thanks for the heads-up. In 5927c96 I moved it to being named I agree we should have this documented in MDN, and the Glossary is the right place. So in that sense at least, |
@jamesaucode Thanks much — this is a great addition to the docs |
It's referenced in several pages including the page I am refactoring: Window.open, and other pages like contentWindow, MessageEvent.source etc. So it will be nice to have a page dedicated to it.
N/A, new page will be created with slug 'Glossary/Window_Proxy'
N/A
I am actually not sure if this should go under Glossary or Web/API ? Correct me if I am wrong but we don't instantiate a
WindowProxy
project, but we work with the Window object. When we check the instance of the global window object, it also returnsWindow
.(window instanceof Window) === true
. Let me know where this page should be in.