Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace tbd with a bit more verbose version #7561

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Conversation

Ryuno-Ki
Copy link
Collaborator

@Ryuno-Ki Ryuno-Ki commented Aug 3, 2021

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'

It does not „fix” the issue, but refs #7445 - a proper solution is still required (but not easily achieved - see the ticket)

What was wrong/why is this fix needed? (quick summary only)

„tbd” looked broken. I assume, it's a leftover from the wiki times after an editathon.

Anything else that could help us review it

It would be great if there were a template to follow so that all ARIA pages could be brought into a similar shape in a concerted action.

@Ryuno-Ki Ryuno-Ki requested a review from a team as a code owner August 3, 2021 19:48
@Ryuno-Ki Ryuno-Ki requested review from ericwbailey and removed request for a team August 3, 2021 19:48
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/Tab_Role
Title: ARIA: tab role
on GitHub

No new external URLs

Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you for doing this!

@ericwbailey ericwbailey merged commit 8114d5a into main Aug 3, 2021
@ericwbailey ericwbailey deleted the aria-tab-replace-tbd branch August 3, 2021 20:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants