Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove seoSummary, part 1 #8114

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Aug 20, 2021

This is the first of two PRs to remove all seoSummary classes from the Web/API docs, in cases where seoSummary just marks up the first (non-macro) paragraph in the page. In cases like this, seoSummary has no effect, and can therefore be safely removed.

This is part of #8110.

@wbamberg wbamberg requested a review from a team as a code owner August 20, 2021 02:45
@wbamberg wbamberg requested review from jpmedley and removed request for a team August 20, 2021 02:45
@github-actions

This comment has been minimized.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did 3 passes:

  • checked the preview of each page
  • checked the cases where the HTML of the first paragraph was over several lines
  • checked the cases where the HTML of the first paragraph spanned only one line

@teoli2003 teoli2003 merged commit b246c06 into mdn:main Aug 20, 2021
@teoli2003
Copy link
Contributor

Great work, @wbamberg !

wbamberg added a commit to wbamberg/content that referenced this pull request Aug 20, 2021
…remove-seosummary-nomatch

* origin/remove-seosummary-nomatch:
  Fixed typo (mdn#8139)
  Fix link to fragment on same page (mdn#8128)
  Fix sectioning problem and remove redirect in Using the Painting API (mdn#8130)
  Fix sectioning flaw in WebGL Boilerplate #1 (mdn#8131)
  Remove {{draft}} from HTMLMediaElement.videoTracks (mdn#8129)
  Replace Intl/* with Intl.* (mdn#8136)
  chore(deps): bump @mdn/yari from 0.4.723 to 0.4.731 (mdn#8135)
  Convert Houdini docs to markdown
  Rename Houdini docs from .html to .md
  Move Web/Houdini to Web/Guide/Houdini
  Move files to CSS/CSS_Backgrounds_and_Borders (mdn#8121)
  Fix live sample box size in font-synthesis (mdn#8120)
  Remove all occurrences of dragexit event and ondragexit h… (mdn#8113)
  Clarify “How the Web works” section describing parse order (mdn#8108)
  Fix a link in Global_Objects/Object/propertyIsEnumerable (mdn#8119)
  Remove seoSummary, part 2 (mdn#8115)
  Remove seoSummary, part 1 (mdn#8114)
  index.html: typo (match </th> with opening <th>) (mdn#8112)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2022
@wbamberg wbamberg deleted the remove-seosummary-matches-1 branch October 15, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants