Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markdown] [Web/HTML] Remove page macro from input element pages #9033

Merged
merged 2 commits into from
Sep 19, 2021

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Sep 17, 2021

Part of #8961.

This removes uses of the {{page}} macro from the <input> docs. This change is sometimes needed for Markdown because {{page}} sometimes wanted to select part of a section using a <div>. I suppose I could have kept {{page}} when it wanted complete sections, by adjusting heading IDs, but it seemed better to get rid of it entirely.

So now there is quite a lot of duplication in the lists of attributes on input type pages.

I think what we ought to do here eventually is:

But I didn't want to get into that today.

@wbamberg wbamberg requested a review from a team as a code owner September 17, 2021 19:32
@wbamberg wbamberg requested review from estelle and removed request for a team September 17, 2021 19:32
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2021

Preview URLs

Flaws

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTML/Element/input
Title: <input>: The Input (Form Input) element
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/checkValidity does not exist
    • /en-US/docs/Web/API/HTMLInputElement/setCustomValidity does not exist
    • /en-US/docs/Web/API/ValidityState/valueMissing does not exist
    • /en-US/docs/Web/API/ValidityState/valueMissing does not exist
    • /en-US/docs/Web/API/ValidityState/valid does not exist
    • and 1 more flaws omitted

URL: /en-US/docs/Web/HTML/Element/input/range
Title: <input type="range">
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/valueAsNumber does not exist

URL: /en-US/docs/Web/HTML/Element/input/email
Title: <input type="email">
on GitHub
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Attributes/list
    • Can't resolve /en-US/docs/Web/HTML/Attributes/list
    • Can't resolve /en-US/docs/Web/HTML/Attributes/placeholder

URL: /en-US/docs/Web/HTML/Element/input/search
Title: <input type="search">
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist

URL: /en-US/docs/Web/HTML/Element/input/week
Title: <input type="week">
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist

URL: /en-US/docs/Web/HTML/Element/input/password
Title: <input type="password">
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Glossary/OS does not exist
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
    • /en-US/docs/Web/API/HTMLInputElement/selectionStart does not exist
    • /en-US/docs/Web/API/HTMLInputElement/selectionEnd does not exist
    • /en-US/docs/Web/API/HTMLInputElement/selectionDirection does not exist

URL: /en-US/docs/Web/HTML/Element/input/month
Title: <input type="month">
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist

External URLs

URL: /en-US/docs/Web/HTML/Element/input
Title: <input>: The Input (Form Input) element
on GitHub


URL: /en-US/docs/Web/HTML/Element/input/range
Title: <input type="range">
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/input/email
Title: <input type="email">
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/input/url
Title: <input type="url">
on GitHub


URL: /en-US/docs/Web/HTML/Element/input/number
Title: <input type="number">
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/input/text
Title: <input type="text">
on GitHub


URL: /en-US/docs/Web/HTML/Element/input/search
Title: <input type="search">
on GitHub


URL: /en-US/docs/Web/HTML/Element/input/week
Title: <input type="week">
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/input/password
Title: <input type="password">
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/input/time
Title: <input type="time">
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/input/tel
Title: <input type="tel">
on GitHub


URL: /en-US/docs/Web/HTML/Element/input/month
Title: <input type="month">
on GitHub

No new external URLs

(this comment was updated 2021-09-19 09:25:57.686918)

@sideshowbarker sideshowbarker merged commit 47d5efb into mdn:main Sep 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
@wbamberg wbamberg deleted the remove-page-html-input branch October 15, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants